richid / services_scribd Goto Github PK

On line 60 is an array $_validDocTypes. This arraiy is used in function upload() (line 271). The document types in the array
are used for the function getDownloadUrl(). The function upload() can handle a lot more document types. I added the array
$_validDocTypesUpload and used this variable on line 271 in the function upload ().

So there is an difference between the document types for uploading and for downloading. When downloading the document types "pdf", "txt", "original" are used (http://www.scribd.com/developers/api?
method_name=docs.getDownloadUrl). When uploading there are a many more document types which can be used (http://www.scribd.com/developers/api?method_name=docs.upload)

Original report: https://pear.php.net/bugs/bug.php?id=19067

Services_Scribd::timeout is set to 10 seconds, which is fine with most requests.

But on upload (Services_Scribd_Docs::upload()), the timeout sometimes is too soon when the file is big & the connection is not as fast as it should be. Upload fails with Exception Message "Request timed out after 10 second(s)"

I'd suggest making the timeout setting configurable (per upload request as parameter, per method or whatever coding style is PEAR-appropriate)

Original report: https://pear.php.net/bugs/bug.php?id=16746