richclubb / python-lin Goto Github PK

In LinBus.py slaveResponseFrameEntry is populated twice (see line 68). The first is fine, but the second has checksum set to Enhanced. This is incorrect, and should be removed.

Is there any plan to add vector driver integration as is available in python-can?

When receiving messages, only diagnostic identifiers are correctly handled. There are specific references to the two diagnostic PIDs. It will be better to strip the chack bits from the PIDs and send up the ID to the upper layers.

In Uds.py:

If a request is sent with suppressRespose=True, the response is still tested for "response pending" (0x78), even though response is None. See code starting at line 140.

The response pending would only work for a single response pending too. There could be several.

Perhaps replace with this:

      if responseRequired:
           while True:
               response = self.tp.recv(self.__P2_CAN_Client)
               if not ((response[0] == 0x7F) and (response[2] == 0x78)):
                   break

There is a new CXPI interface based on the LIN physical layer:
https://de.wikipedia.org/wiki/CXPI
(Sorry only available in German language)

Do you think in general it would make sense to integrate this in the module?
Do you have already any plans to integrate this in the module?

I don't see any support for Vector devices.
Is there any plan to add it in the near future?