Comments (1)
Splitting the model will be problematic for doing queries (and the model would need to be tweaked even further, because Comments belong to Patchsets right now, and non-editors should be able to leave Comments).
If AuthedModel could keep an accurate list of which properties have been altered for the 'update' action, then the can_update(self) method could behave conditionally on that list.
from rietveldv2.
Related Issues (20)
- Is line-indexing for comments correct?
- new upload.py testing thoughts
- Add tooling to inspect the previous test result HOT 1
- Make email sending actually work
- It would be great if replying to email would enable inline comment responses
- How to store Comment/Message data in Datastore? HOT 2
- Test framework should be able to be applied against real appengine deployment
- Should collaborators/bug/etc. be real fields?
- Should allow description to be reviewed as part of the review.
- Should use new AuthedModel field modification ability to restrict the fields on every model.
- Should the uploadv2 module dir be restructured? HOT 1
- There should be a way to explicitly control the "Copy"/"Move" semantics
- General ability to edit patchsets via web interface.
- Allow patch views to automatically expand columns to match the source file
- Incorporate changes from the Rietveld Usability Toolkit chrome extension
- Need scheme for developing new UIs on live service. HOT 3
- CQ's UI on Rietveld needs to be properly designed HOT 2
- Sending Messages needs to be idempotent HOT 5
- Add Access-Control-Allow-Origin header HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rietveldv2.