Giter Club home page Giter Club logo

Comments (6)

Freed-Wu avatar Freed-Wu commented on June 13, 2024

It works for me.

# ...
  - repo: https://github.com/Freed-Wu/actionlint
    rev: v1.6.25
    hooks:
      - id: actionlint
$ pre-commit run -a
[INFO] Initializing environment for https://github.com/Freed-Wu/actionlint.
...
Lint GitHub Actions workflow files............................................Passed
...

Environments:

$ go version
go version go1.20.4 linux/amd64
$ uname -r
6.3.2-arch1-1

from actionlint.

dokempf avatar dokempf commented on June 13, 2024

@Freed-Wu Please, I already told you in #301: The v1.6.25 tag of your fork does not include your change to golang. You are not testing what you think you do.

from actionlint.

Freed-Wu avatar Freed-Wu commented on June 13, 2024

#297 (comment) This comment is written before #301 (comment), at that time, I haven't known this bug. Now it should be fixed.

from actionlint.

rhysd avatar rhysd commented on June 13, 2024

pre-commit runs go install ./..., but this fails in the actinolint repo.

It looks a problem of pre-commit. The package path ./... should be configurable in pre-commit side. Changing main package path means largely changing package structure of this repository. It affects all packages which is using actionlint as Go library. It should not be changed only for avoiding the problem of pre-commit.

from actionlint.

rhysd avatar rhysd commented on June 13, 2024

I may be able to add some build tag to excluding the Wasm package.

from actionlint.

rhysd avatar rhysd commented on June 13, 2024

I added //go:build wasm tag to the module under playground directory. Now go install ./... should work.

from actionlint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.