Giter Club home page Giter Club logo

Comments (7)

rhysd avatar rhysd commented on June 15, 2024

This is because the action does not define the output in the manifest. I'll make a pull request there.

https://github.com/google-github-actions/get-secretmanager-secrets/blob/main/action.yml

from actionlint.

rhysd avatar rhysd commented on June 15, 2024

Created: google-github-actions/get-secretmanager-secrets#283

from actionlint.

dragon3 avatar dragon3 commented on June 15, 2024

@rhysd
Thank you for the comment and for creating the pull request.

However, the google-github-actions/get-secretmanager-secrets creates the outputs dynamically from the secrets attribute.

For example, the following configuration creates foo1 and bar2 outputs dynamically.

    - id: 'secrets'
      uses: 'google-github-actions/get-secretmanager-secrets@v2'
      with:
        secrets: |-
          foo1:xxx
          bar2:xxx

# The dynamic outputs can be used in other steps
# ${{ steps.secrets.outputs.foo1 }}
# ${{ steps.secrets.outputs.bar2 }}

Do you have any idea to support that on actionlint?

from actionlint.

rhysd avatar rhysd commented on June 15, 2024

Ah, I see. Then it is not possible to know what output names are used statically.

from actionlint.

dragon3 avatar dragon3 commented on June 15, 2024

Thank you for the comment and for making the change!

I'm looking forward to the next release with the change. Do you have a plan to release it soon?

Thank you!

from actionlint.

rhysd avatar rhysd commented on June 15, 2024

Currently not planned. But I understand that I should make releases more frequently. Meanwhile, would you ignore the error by -ignore or use the latest main branch?

from actionlint.

dragon3 avatar dragon3 commented on June 15, 2024

Thank you for the comment, and sorry for the late reply.

Currently not planned. But I understand that I should make releases more frequently.

I see. No problem, take your time 👍

Meanwhile, would you ignore the error by -ignore or use the latest main branch?

I got it. It's not urgent for me, and I will try either way you suggested if necessary.


Thank you for working on the great product. I appreciate that 👍

from actionlint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.