Giter Club home page Giter Club logo

safety-shift-plot's People

Contributors

dependabot[bot] avatar jwildfire avatar mhickle avatar nbryant avatar pburnsdata avatar samussiah avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

samussiah

safety-shift-plot's Issues

Enhance axes

  1. Update axis label according to measure/visit selections. For example:
    Baseline Value -> Calcium (V0)
    Comparison Value -> Calcium (V1-V7)

  2. Option for log axis

  3. Option to adjust axis ranges

Add test page.

Test notes

  • A test page exists in build/test-page.
  • Once released, the test page can be viewed here.

safety-shift-plot not drawing where expected in webcharts v1.10.0

safety-shift-plot loads using Webcharts v1.10.0-dev, but the drawing is off when I try to select several points in the charts. When I click with my mouse and drag it, I expect it to draw a box in the are where I clicked and dragged, but it draws the box beginning in the top left corner of the chart every time.

Also, once drawn, I cannot click out of the box to get the drawn box to disappear and show the chart with no box without re-rendering the whole chart.

Default time_col to VISIT and add visit order variable setting.

Test notes

  • Visit controls display visit descriptions rather than visit numbers.
  • Visits appear in Baseline Visit(s) and Comparison Visit(s) ordered by the corresponding visit number value.
  • If the visit number variable does not exist or is not specified then visits are ordered alphanumerically.

Show # of Enrolled/Randomized Participants

Not sure the best way to handle this, but it would be good to have the number of relevant study participants shown somewhere on the chart. Maybe add a footnote for "X of X participants shown in this view"

Table should be hidden on initial load

Issue introduced in webcharts v1.9

Test notes

  • The detail listing isn't visible initially.
  • The detail listing displays as expected upon brushing the chart.

Make axes ranges stay consistent when using a filter

From Meagan Spychala on 9/19:

"It would be really useful if the axes’ ranges stayed consistent when using a filter. For example, we were looking at a longitudinal graphic of systolic blood pressure across several sites, but each site’s graphic had an updated vertical range to fit that site, it did the use aggregate of the data (i.e. if the SBP for the study as a whole was 70 to 160, but a site’s range was 90-120, the 90-120 would be the vertical axis range for that site only) . Because the range of the vertical (SBP) and horizontal (Visit) axes can change, it is harder to see if the sites were in line with each other or if there was an outlying site. I think it’s appropriate to have the range of the axes change depending on the measure (for example, SBP vs. DBP), but once you pick a measure, the axes’ range should be held constant based upon the overall data to be able to identify potential trends."

Update settings merge process

Use the Results over Time as a prototype to update the settings merge process

Test notes

  • Code-facing issue so no feature testing required.

Make Wiki

Moved from GG-1375

Details: Britt created wiki in April '16 - please QC

Add visit order settings.

Test notes

  • User can specify visit_order_col that names a variable that orders the visits.
  • Visit ordering can be set two ways: {"visit_col":"VISIT","visit_order_col":"VISITNUM"} to order visits sequentially and {"visit_col":"VISIT","visit_order_col":"VISIT"} to order visits alphanumerically.

Add settings schema.

Test notes

  • A settings schema is present in the root of the repo.
  • The settings schema contains one property for each renderer-specific setting in src/defaultSettings.
  • The form view displays in CAT.

Add Sort by Site Feature

Add feature to sort by site, so they can see AEs (and vitals, labs, etc.) from one site at a time

Update class of custom controls' control label...

...from control-label to wc-control-label to keep in sync with webcharts v1.10.0.

Test notes

  • Run d3.selectAll('.wc-controls .control-label') in the developer console and verify that the selection returns 0 nodes.

Have Equality in Shift Plot

Have equality in shift plot, like x=y. consider annotating the number of points above (increasers) and below (decreasers) the line.

Update data cleaning method.

like safety-results-over-time

Test notes

  • Invalid results are removed from the data rather than measures with any invalid results. Invalid results include missing and non-numeric values.
  • The number of removed results is noted in the console.
  • You can confirm by downloading the data from CAT, updating the STRESN column so a few values are bad. When you reupload the edited data you will see that the number changes appropriately in the console.

Default to settings on the left

screen shot 2017-10-19 at 12 46 26 pm

            #safetyShiftPlot .wc-controls {
                width: 20%;
                float: left;
            }
            #safetyShiftPlot .wc-controls .control-group,
            #safetyShiftPlot .wc-controls .annote {
                display: inline;
                float: left;
                clear: left;
            }
            #safetyShiftPlot .wc-chart {
                width: 39%;
                float: left;
            }

See project 274/archive

Test notes

  • Controls appears to left of chart.

Participant numerator is calculated incorrectly.

  //count the number of unique ids in the current chart and calculate the percentage
    const currentObs = chart.filtered_data
        .filter(d =>
            chart.x.domain()[0] <= d.shiftx <= chart.x.domain()[1] &&
            chart.y.domain()[0] <= d.shifty <= chart.y.domain()[1])
        .length;

webcharts.dataOps.getValType excludes all data when only a few observations exist.

Test notes

  • When a measure contains fewer than five unique values it isn't removed from the data.
  • To test, edit ADBDS so that it contains at least two results for the same measure from the same USUBJID. The shift plot is plotting the baseline value on the x-axis and the comparison value on the y-axis which requires at least two results.

Regression Testing for Shift Plot v2.0.0

Confirm basic functionality and new features are working as expected in examples shown below:

Examples using v.2.0.0 Release Candidate
default
customized

Basic Functionality (Tested every release)

  • Check all spelling and grammar on the page
  • Confirm that measure filter is working as expected: plot points in the table and sites specified for collection both change
  • Confirm that visit filters are working as expected: plot points in the table and number of observations in the table header both change
  • Confirm that detailed record can be viewed by clicking and dragging the mouse across a section of values

New Functionality (Tested in V.2.0.0 only)

  • (#1) Confirm that x and y axes are equal
  • (#2) Confirm that when moused-over, the axis labels display tooltips containing visit information
  • (#8) Confirm that the # of enrolled/randomized participants is visible at the top of the page
  • (#9) Confirm that when selecting multiple filters, the axis ranges stay constant
  • (#10) Confirm that you can filter on the status of a participant (active, discontinued)

Add support for visit order option

When visit order is specified the options in the 2 visit dropdowns should be sorted accordingly.

(Request from Jack)

Test notes

  • The Baseline Visit(s) and Comparison Visit(s) options are sorted appropriately.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.