rhoinc / safety-results-over-time Goto Github PK
View Code? Open in Web Editor NEWTest Results Over Time for Safety Explorer
Home Page: http://rhoinc.github.io/safety-results-over-time/test-page/
License: MIT License
Test Results Over Time for Safety Explorer
Home Page: http://rhoinc.github.io/safety-results-over-time/test-page/
License: MIT License
Math.log10
doesn't exist in IE. Added a polyfill to address. No feature testing needed.Options in Group dropdown are being repeated in all chartfoundry examples
src/defaultSettings
.Can currently have multiple filters for the same column, which can cause problems in certain frameworks as described here
From SE board - helps with scrunched axis
per @dschwentker , sometimes duplicate None options appear when no groupings have been specified
Confirm basic functionality and new features are working as expected in examples shown below:
Examples using v1.3.0 Release Candidate
EXAMPLE(S)
Basic Functionality (Tested every release)
New Functionality (Tested in V1.2.0 only)
time_settings.order_col
if it exists.For example, the ability to filter on "Active" vs. "Discontinued"
Allow users to subset on which tests are displayed (using the chart template)
Check box controls for violin plots and box plots are not being formatted correctly in chartfoundry.
safetyResultsOverTime.js
) lives at the top level of the repo rather than in the build
folder (which is no longer). No feature testing needed....from control-label to wc-control-label to keep in sync with webcharts v1.10.0.
d3.selectAll('.wc-controls .control-label')
in the developer console and verify that the selection returns 0 nodes.Depending on how unscheduled visits are displayed on the x-axis, the chart can have some unintended behavior.
(See related issue for Outlier Explorer: RhoInc/safety-outlier-explorer#68)
If visits are displayed purely chronologically, the challenge is that you end up creating a new event type that shows up in the middle of the data, but for only a small number of data points. See example of visits 2(UN) and 5(UN) below:
Our primary medical monitor user has proposed that to fix this, we sort all Unscheduled visits to the far right end of the chart, where they are still visible, but they don't interfere with seeing the data flow through expected visits.
Proposed solutions:
Test out the new "Visits without data" and "Unscheduled visits" controls in CAT with the safetyData/ADBDS.csv
data file (not safetyData-queries/ADBDS.csv
).
Confirm that:
{groups:["RACE"]}
){"unscheduled_visits":true}
{"visits_without_data": true}
{unscheduled_visit_values:["Unscheduled 2.1","Screening"]}
Bug reported by Kristen on 7/12:
"2. Violin plots in the ‘Results Over Time’ figure are not coloring correctly when you select by group display (all categories are grey)."
Default behavior for rotateX:true isn't being applied in chart-foundry renderer.
Request from Jack:
Jack would like an x-axis control like we have on the Outlier Explorer that would allow him to switch the x-axis from Visit to Day. He wanted this so he could view group means by day. We discussed this and decided that the best approach would be to define the mean or median study day within each visit and plot that on a linear axis.
Jeremy suggested making this a "title on the visit tick marks that is shown on mouseover instead of a separate continuous axis option - keeps the design (and coding) a lot simpler, but gives jack the info he needs. "
Auto-scaling was throwing people off, so add ability to set limits. Or toggle between log axis and linear.
...and default to an existent measure.
start_value
in CAT.Make the scroll-over text reappear
throw a console.warning() instead
ARM
, SEX
, etc.) as well as a group label (Treatment Group, Sex, etc.) and verify the Group dropdown and legend label display the group labels and not the group variable names.src/onInit/cleanData.js
puts a note in console.log when removing non-numeric records, but it would be better if it was displayed for the user. Maybe add a footnote?
also add a no-data check to avoid plotting anything, and check that filtered data actual contains data that matches the current x-domain (e.g. isn't limited to unscheduled visits)
Let's not make Sex and Race required. Change default to: groups: [{value_col: 'NONE', label: 'None'}]
Request from Jack:
Jack needs a higher level of precision on the means of certain measures (e.g., 2 decimal places). The current mean value in the tool-tip view is rounding too high, and doesn’t have adequate precision to answer the questions he is asking.
Replicate for yourself here: http://interactive.it.rhoworld.com/dev/safety-explorers/studies/sunovion-sep360-311/#results-over-time with “LB – Hematocrit” as the Measure).
Currently, the tick values can get a little crunched up when using a log scale. Might be nice to spread them out using some sort of transformation
If not sure if the mouseover data is supposed to display underneath the chart, but it could be helpful/Jack would probably ask for it
per @pburnsdata , and also give them a black stroke or something to make 'em stand out
Not sure the best way to handle this, but it would be good to have the number of relevant study participants shown somewhere on the chart. Maybe add a footnote for "X of X participants shown in this view"
From Meagan Spychala on 9/19:
"It would be really useful if the axes’ ranges stayed consistent when using a filter. For example, we were looking at a longitudinal graphic of systolic blood pressure across several sites, but each site’s graphic had an updated vertical range to fit that site, it did the use aggregate of the data (i.e. if the SBP for the study as a whole was 70 to 160, but a site’s range was 90-120, the 90-120 would be the vertical axis range for that site only) . Because the range of the vertical (SBP) and horizontal (Visit) axes can change, it is harder to see if the sites were in line with each other or if there was an outlying site. I think it’s appropriate to have the range of the axes change depending on the measure (for example, SBP vs. DBP), but once you pick a measure, the axes’ range should be held constant based upon the overall data to be able to identify potential trends."
Measure dropdown options should include units.
unit_col
) to a nonexistent variable name in CAT and re-render the chart. The chart should behave identically, except units are not appended to measures.Add feature to filter by site, so they can see AEs (and vitals, labs, etc.) from one site at a time
Currently the chart's range is based on the total range of the data, but no points are drawn for outliers above the 95th or below the 5th percentile (as shown below).
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.