reviversmc / advanced-tooltips Goto Github PK

Will you port the 1.18.2 version? It's only available for Quilt too

Just leaving this here for you records, appreciate your work :) Just starting to have some crashes when I added Litematica but running tons of mods so I know how it is. Can give you the full log if you're interested.

java.lang.NullPointerException: Cannot invoke "net.minecraft.class_5684.method_32664(net.minecraft.class_327)" because "comp" is null
	at com.github.reviversmc.advancedtooltips.tooltip.CompoundTooltipComponent.method_32664(CompoundTooltipComponent.java:55)
	at net.minecraft.class_437.method_32633(class_437.java:204)
	at net.minecraft.class_437.method_32634(class_437.java:177)
	at net.minecraft.class_437.method_25409(class_437.java:168)
	at net.minecraft.class_481.method_25409(class_481.java:731)
	at net.minecraft.class_465.method_2380(class_465.java:189)
	at net.minecraft.class_481.method_25394(class_481.java:692)
	at net.minecraft.class_757.method_3192(class_757.java:881)
	at net.minecraft.class_310.method_1523(class_310.java:1177)
	at net.minecraft.class_310.method_1514(class_310.java:768)
	at net.minecraft.client.main.Main.method_44604(Main.java:244)
	at net.minecraft.client.main.Main.main(Main.java:51)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

Details:
	Minecraft Version: 1.19.2
	Minecraft Version ID: 1.19.2
	Operating System: Linux (amd64) version 6.2.8-arch1-1
	Java Version: 17.0.6, N/A
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 447962408 bytes (427 MiB) / 3577741312 bytes (3412 MiB) up to 4294967296 bytes (4096 MiB)
	CPUs: 16
	Processor Vendor: AuthenticAMD
	Processor Name: AMD Ryzen 7 5700G with Radeon Graphics
	Identifier: AuthenticAMD Family 25 Model 80 Stepping 0
	Microarchitecture: Zen 3
	Frequency (GHz): -0.00
	Number of physical packages: 1
	Number of physical CPUs: 8
	Number of logical CPUs: 16
	Graphics card #0 name: Cezanne [Radeon Vega Series / Radeon Vega Mobile Series]
	Graphics card #0 vendor: Advanced Micro Devices, Inc. [AMD/ATI] (0x1002)
	Graphics card #0 VRAM (MB): 258.00
	Graphics card #0 deviceId: 0x1638
	Graphics card #0 versionInfo: unknown
	Virtual memory max (MB): 19786.51
	Virtual memory used (MB): 7860.46
	Swap memory total (MB): 4096.00
	Swap memory used (MB): 0.00
	JVM Flags: 2 total; -Xms512m -Xmx4096m

Hovering over spawn eggs from BetterEnd mod causes a crash:

https://bytebin.lucko.me/SDBgvZ0MH4

When playing hovering over any type of armor with a modifier results in a crash due to "Unknown TooltipComponent"

crash-2023-02-06_18.27.42-client.txt
crash-2023-02-06_18.40.07-client.txt
crash-2023-02-06_18.41.02-client.txt

this seems to be the case for all modified Armor items Including: Helmet, Chestplate, Leggings, Boots

possible solution much aprreciated

Seem to struggle to know wich texture to render in egg spawner tooltip when the resource pack have optifine random entities.

crash-report.txt

After further testing, these are the items where it crashes:

• Beetroot Soup
• Mushroom Stew
• Rabbit Stew
• Suspicious Stew
• Melon Slice
• Honey Bottle

When searching for "spectral" in the creative menu, hovering over the egg that is related to the keyword "spectral" causes a crash:

https://crashy.net/27a5cfa8-8786-474f-abc9-3076ef619711

https://bytebin.lucko.me/VRbNPcwGON

The command to reload the settings is /advancedtooltips config reload

Crashes when hovering "Shears" in inventory

Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_5684.method_32664(net.minecraft.class_327)" because "comp" is null at com.github.reviversmc.advancedtooltips.tooltip.CompoundTooltipComponent.method_32664(CompoundTooltipComponent.java:55) ~[advanced-tooltips-core-1.6.0-8cd83e1b3be750dd.jar:?] at satisfyu.vinery.util.TooltipHelper.newFix(TooltipHelper.java:22) ~[vinery-1.2.5.jar:?] at net.minecraft.class_437.handler$ple000$vinery$fix(class_437.java:17219) ~[client-intermediary.jar:?] at net.minecraft.class_437.method_32633(class_437.java:202) ~[client-intermediary.jar:?] at net.minecraft.class_437.method_32634(class_437.java:177) ~[client-intermediary.jar:?] at net.minecraft.class_437.method_25409(class_437.java:168) ~[client-intermediary.jar:?] at net.minecraft.class_465.method_2380(class_465.java:189) ~[client-intermediary.jar:?] ... 7 more

Mob spawners seem to be unaffected by the mod, no additional info shows up in the tooltips. Neither is the mob_spawner entry listed in the command /advancedtooltips config effects..

When a mob from biome makeover mod is rendered in a spawn egg tooltip, the mob´s ambience start looping in the area where the tooltip is triggered multiple times resulting in my eardrums reporting minecraft for molestation

I don´t know if other mods are affected, but if you want to test it out, the easiest example is the dragonfly tooltip from biome makeover:
https://www.curseforge.com/minecraft/mc-mods/biome-makeover

update: while testing this in a superflat world, dragonfly noises popped out of nowhere (with no dragonfly around), so I disabled the egg render feature, fixing it

Add version to MC 1.19.4

When will they make a port from quilt to fabric 1.19.3?

Reproduction steps

1. go to a world with creative

/give @s bat_spawn_egg{EntityTag:{DeathLootTable:"Emerald"}}

3. look at the tooltip of the item
4. crash

Additional info

Crash log: https://gist.github.com/Zailer43/75177b0640b523dd6d3a37f918ded199
Advanced tooltips: 1.6.0+1.19

🙏🏽

Hey, @NebelNidas, or whoever ported the "Inspecio" mod from Quilt to Fabric, could you make a 1.19.3 version of the mod, "Advanced Tooltips"? The reason I want it for 1.19.3, is because that is my main client version.