This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Error occurs when using windows/macOS GitHub runners

Related Logs

Installing shellcheck ... https://github.com/koalaman/shellcheck
  D:\a\_actions\reviewdog\action-shellcheck\v1/script.sh: line 8: wget: command not found
  xz: (stdin): File format not recognized
  tar: Child returned status 1
  tar: Error is not recoverable: exiting now
  cp: cannot stat 'shellcheck-v0.9.0/shellcheck': No such file or directory
 Running shellcheck ...
  D:\a\_actions\reviewdog\action-shellcheck\v1/script.sh: line 72: shellcheck: command not found
  reviewdog: EOF
 Running shellcheck (suggestion) ...
  D:\a\_actions\reviewdog\action-shellcheck\v1/script.sh: line 88: shellcheck: command not found
Error: Process completed with exit code 1.

How do I exclude multiple folders? I have tried :
exclude: './.git/* , ./vendor/*'
exclude: './.git/* ./vendor/*'

Many shell scripts have no '.sh' suffix and but if we omit the pattern, this action checks all files in the repo except those excluded. This isn't terribly useful.

It would be nice if the files could be filtered by their shebang somehow.

I'm actively exploring what's going on here - in Magma's GH Action execution of hadolint. This has started failing very recently with the below.

Error message.

 Running hadolint with reviewdog 🐶 ...
  reviewdog: This is Pull-Request from forked repository.
  GitHub token doesn't have write permission of Review API, so reviewdog will
  report results via logging command [1] and create annotations similar to
  github-pr-check reporter as a fallback.
  fatal: ls-files -i must be used with either -o or -c
  [1]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands
  parse error: Invalid numeric literal at line 1, column 7
  reviewdog: parse error: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token 
Error: Process completed with exit code 1.

Our GH Action.

name: reviewdog
on: [pull_request]
jobs:
  shellcheck:
    name: runner / shellcheck
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - name: shellcheck
        uses: reviewdog/action-shellcheck@v1
        with:
          github_token: ${{ secrets.github_token }}
          filter_mode: added # Any added or changed content.
          reporter: github-pr-review # Post code review comments. Falls back to Annotations.
          pattern: "*.sh" # Optional.
          # Other options omitted here but possible.
          # - fail_on_error
          # - path
          # - exclude
          # - shellcheck_flags

Hi there-

We're using this action with reporter: github-pr-review, and when an issue can be fixed by suggestion, we get two comments:

Is it possible to avoid this and only get the [shellcheck (suggestion)] comment when something is auto-fixable and only get the [shellcheck] comment when it's not?

Or, ideally, they should be combined:

[shellcheck] reported by reviewdog

Double quote to prevent globbing and word-splitting. SC2086

- echo $example
+ echo "$example"

Testing running this in a repo with the following path:
/src/content/space space/super-bad.sh

Results in the following:

src/content/space: src/content/space: openBinaryFile: does not exist (No such file or directory)
space/super-bad.sh: space/super-bad.sh: openBinaryFile: does not exist (No such file or directory)

It appears spaces are not handled.

Action run log: https://github.com/folderol4/shellcheck-test/actions/runs/3236420628/jobs/5302204371

I've configured level: style and while that produces quite a few errors locally, reviewdog/action-shellcheck does not fail the build. None of the errors I see locally are printed anywhere by reviewdog/action-shellcheck. Have I configured it wrong, somehow?

- name: Shellcheck
  uses: reviewdog/action-shellcheck@v1
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    reporter: github-pr-review
    level: style

Hi, I am having a couple of issues with using this action and I would like to receive help.

1) The first thing is that a warning message is being displayed when I use it. I would like to know if this is completely normal or is it a bug?

2) The second thing is, I'd like to know how I can run shellcheck over my entire file, rather than just the diff.
I have tried using the filter_mode: nofilter and filter_mode: file parameters but they were not successful (it may be due to the previous error)

The same message for both was:

3) And finally, I have spaghetti code in my action because I want to run shellcheck against a lot of different files that don't have any similitude in the name, is there any solution for it?

Here is my action:

name: Linter [develop]

on:
  pull_request:
    branches:
      - develop

jobs:
  linter:
    name: Linter
    runs-on: ubuntu-latest

    steps:
      - name: Checkout Code
        uses: actions/checkout@v2

      - name: Super-Linter
        uses: github/[email protected]
        env:
          VALIDATE_ALL_CODEBASE: false

      # Spaghetti code

      - name: shellcheck for ~/.zshrc
        uses: reviewdog/[email protected]
        with:
          pattern: ".zshrc"
          github_token: ${{ secrets.REVIEWDOG_GITHUB_API_TOKEN }}
          filter_mode: file
          shellcheck_flags: '-s sh -e 1090,2004,2039'

      - name: shellcheck for ~/.local/bin/change-background
        uses: reviewdog/[email protected]
        with:
          pattern: "change-background"
          github_token: ${{ secrets.REVIEWDOG_GITHUB_API_TOKEN }}
          filter_mode: file
          shellcheck_flags: '-s sh -e 1090,2004,2039'

      - name: shellcheck for ~/.local/bin/start-script
        uses: reviewdog/[email protected]
        with:
          pattern: "start-script"
          github_token: ${{ secrets.REVIEWDOG_GITHUB_API_TOKEN }}
          filter_mode: file
          shellcheck_flags: '-s sh -e 1090,2004,2039'

Thanks for your time ⭐

Hi,

I am considering opening a pull request against this repository (see #2), but currently this repository is missing a license file.

Hi! this may be a stupid question so I'm sorry in advance if this is not the place for it.

When reviewdog reviews a PR with shellcheck, does it look only at the changes made in the PR or does it look at everything in the repo?

I have a bash repo in which I want to use this action, but shellcheck has a lot of problems with it so checking the codebase with shellcheck right now is pretty much useless since every file will be flagged with something.
I wanted to avoid introducing even more problems in the repo while I fix all shellcheck complaints, so I wanted to run shellcheck only on the things changed in the PR. Is this something possible to do with this action? Will this action only spot the new problems introduced in the PR or will it complain about everything that was already wrong even before the PR?

Thank you for your time and the amazing tool!