In Firefox 37.0.1 and Chromium 41.0.2272.76, I get this error when loading my require.js app with domReady during the page load:

Error: Script error for: domReady
http://requirejs.org/docs/errors.html#scripterror

Then, when I refresh, the error doesn't occur again.

Many users on my site are getting this error, logged with a ravenjs/sentry setup.

Older browsers do not set the document.readyState property. So I usually change your code. Is it possible to provide similar checks in the native code?

   //Check if document already complete, and if so, just trigger page load
    //listeners. Latest webkit browsers also use "interactive", and
    //will fire the onDOMContentLoaded before "interactive" but not after
    //entering "interactive" or "complete". More details:
    //http://dev.w3.org/html5/spec/the-end.html#the-end
    //http://stackoverflow.com/questions/3665561/document-readystate-of-interactive-vs-ondomcontentloaded
    //Hmm, this is more complicated on further use, see "firing too early"
    //bug: https://github.com/requirejs/domReady/issues/1
    //so removing the || document.readyState === "interactive" test.
    //There is still a window.onload binding that should get fired if
    //DOMContentLoaded is missed.
    if (document.readyState === "complete" || ! document.readyState) {
    //-------------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^
        pageLoaded();
    }

Hello,

There is a bug in your domReady plugin, in line 58 :

document.addEventListener("DOMContentLoaded", pageLoaded, false);

In this case, you are not sure that the DOM can be manipulate (I experienced some problem with jQuery and lazyloading).
To be sure that the DOM can be manipulate you must execute pageLoaded in async mode :

document.addEventListener("DOMContentLoaded", function(){setTimeout(pageLoaded, 1);}, false);

Aside from that, I worked at monde.fr, we use require and it's really great. Thanks for your work.

Hey All,

On line 24...

    function runCallbacks(callbacks) {
        var i;
        for (i = 0; i < callbacks.length; i += 1) {
            callbacks[i](doc); // HERE
        }
    }

...I'm getting the following error:

TypeError: callbacks[i] is not a function
    callbacks[i](doc);

Anyone seen this before? Any ideas?

Thanks for your help.

Sincerely,
Keith kjm

Hi,

where can I find domReady as npm package? The package called domready on npm is from somebody else.

-- ooxi

Hey there,

is there a reason for the initial check in line 91 is only for 'complete', not also for 'interactive'. Since 'interactive' marks the state of having sent the DOMContentLoaded event it seems appropriate to me.

In my setup domReady seems to initialize shortly after the DOMContentLoaded event has fired and therefore waits all the way till the window.load event fires. Because of some big images on the site this means a lot of time.

Thanks for your opinion
Tobi

While a bower.json file was added as pull request #14 the 2.0.1 tag is still marking a previous commit so when bower pulls tag 2.0.1 the bower.json file is missing. Can you please either update the tag or tag with 2.0.2 or something so this is fixed?

NPM reports another package under the 'domready' handle. Is this one installable via NPM?

Not sure if this is directly related to domReady... but, given a package.json configuration:

{
  "devDependencies": {
    "domReady": "github:requirejs/domReady"
  }
}

Yarn install fails, because (I'm guessing here) it can't find the right package on NPM:

error An unexpected error occurred: "ENOENT: no such file or directory, lstat '/Users/username/Library/Caches/Yarn/npm-domReady-2.0.1-3ab6964ba262be995e56452d91b6342f025d30ef'".

I'm wondering, could this library be published properly to NPM? I know npm and yarn can resolve github URLs, but it's nicer having things in NPM when looking things up.

In require.js you use:

isBrowser = !!(typeof window !== 'undefined' && navigator && document)

This may be an intentional difference, but I didn't manage to track down a reason for it.

Thanks

It appears that code that has domReady! as a dependency will never be called if there is a call to require.config({}) later.

<!DOCTYPE html>
<html>
<head>
    <script data-main="/static/js/app-test.js" src="/static/js/lib/require.js">
    </script>
</head>
<body>Testing</body>
</html>

// app-test.js
require(['domReady'], function(domReady){
    domReady( function(){
        console.log('domReady plugin callback fired at ' + new Date().getTime() );
    });
});

require(['domReady!'], function(){
    console.log( 'domReady! plugin fired at ' + new Date().getTime() );
});

require.config({ });

Results in:

domReady plugin callback fired at 1343740124501 app-test.js:3
Uncaught Error: Load timeout for modules: domReady!_unnormalized2_unnormalized3
http://requirejs.org/docs/errors.html#timeout require.js:192

Of course, it is odd to call require.config() in this manner, but this was the simplest example I could find that demonstrates the issue. In real code, I have a require.config() call in a separate javascript file that is included on some pages. None of the code in my first module was executing when the second file was required.

I have tested this is Chrome and Safari on OS/X, using RequireJS 2.0.4 and domReady 2.0.0.

BTW, thanks for writing, releasing and maintaining RequireJS!

hello

There is a reason why this plugin has not been added into RequireJs NPM package?
https://www.npmjs.org/package/requirejs

for example using the usual namespace requirejs-domready?

I'm running IE9 and the domReady plugin is firing early.

I stepped through the code and tracked it down.

    //Check if document already complete, and if so, just trigger page load
    //listeners. Latest webkit browsers also use "interactive", and
    //will fire the onDOMContentLoaded before "interactive" but not after
    //entering "interactive" or "complete". More details:
    //http://dev.w3.org/html5/spec/the-end.html#the-end
    //http://stackoverflow.com/questions/3665561/document-readystate-of-interactive-vs-ondomcontentloaded
    if (document.readyState === "complete" ||
        document.readyState === "interactive") {
        pageLoaded();
    }

For some reason IE9 is setting the readyState to interactive before it even parses the <body>. Here is what I found when I had a break point on pageLoaded();

window.document.getElementsByTagName('head') 
{
0 : {...},
length : 1,
item :  function item() {     [native code] } ,
namedItem :  function namedItem() {     [native code] } 
} 

So the document has a head at that point as it should.

window.document.getElementsByTagName('body') 
{
length : 0,
item :  function item() {     [native code] } ,
namedItem :  function namedItem() {     [native code] } 
} 

But the body doesn't even exist yet and it has the readyState === "interactive"

This is an issue I ran into a long while ago. I originally submitted a pull request to add document.readyState === "interactive" as one of the valid readyStates. requirejs/requirejs#137. I ran it in production for a while and would randomly see dom load errors on IE. This caused me to back it out. So I think we need to remove the readyState === "interactive" check.

Raul

Can you create a bower component package for domReady like you did for RequireJS and RequireJS-text?

Thanks much,
Cary