repairshopr / autoprintr-wpf Goto Github PK

I have a printer that is no where near our AutoPrintr machine, and needs to be shared on the network. I have the printer connected to the AutoPrintr machine via network share. It does not show up in AutoPrintr as a selectable printer. Is there a setting I have to change to make this work?

Description of Issue:
The AutoPrintr service fails to function if the internet connection is lost. A service restart is required to restore functionality.

Reproduction:
I was able to reproduce the connection issue in a test environment, using a test harness with a test pusher account and simulating a connection loss by enabling/disabling the ethernet port. The bug appears to be the result of flaky connection handling in the PusherClient library.

Proposed Solution:
After reviewing this commit, it was noted that the PusherClient library was updated from 0.51 to a custom fork (see here). From review of the commit, it looks like some changes were made in an attempt to correct a re-connection issue.

I did some testing with the original 0.51 and the newer 1.0.1-beta PusherClient versions and did not see the same issue that is occurring with the custom fork. At this point, the recommend solution is to roll back the above change and revert back to, and upgrade to a more recent 1.0.1-beta version, of the main PusherClient library. To use the newer 1.0.1-beta version we also need to update the projects from .NET from 4.5 to 4.6.2.

To Do:

• Update projects to .NET 4.6.2
• Setup Test Harness
• Remove Custom Fork PusherClient reference and external DLL
• Add 1.01-beta PusherClient package
• Test Solution
• Bump Version
• Update Installer

Notes:
After updating the packages there were several additional issues occuring which required a few custom modifications to the PusherClient 1.01-beta. I added the PusherClient project source to the solution and made a few changes to prevent the service from crashing on websocket errors.