@rematch/select type error. about rematch HOT 8 OPEN

Reselect changed his internal typings in a minor version, and that probably caused our @rematch/select typings to fail.
We'll need to look into this more deeply.

from rematch.

I'm willing to fix it. But I'm new here, perhaps need your help.

from rematch.

@tianzhich

from rematch.

I'm willing to fix it. But I'm new here, perhaps need your help.

No problems. Feel free to ask here for any questions you encountered.

from rematch.

To be honest the rematch doesn't 100% compatible with reselect. There are so many @ts-ignore in the codebases. If you are familiar with reselect we could try to fix them together.

from rematch.

To be honest the rematch doesn't 100% compatible with reselect. There are so many @ts-ignore in the codebases. If you are familiar with reselect we could try to fix them together.

With old reselect we weren't, but with new reselect we could be 100% compatible, now his types are so easily compared to older ones. (They passed from 1000 lines to just 115)
https://github.com/reduxjs/reselect/blob/master/src/types.ts

They rewrote his codebase to TS and now they're only compatible with TypeScript 4.2+. We could ship a fix for this on a major version of @rematch/select,

In this way our users could use:

• Rematch + Reselect(<4.1.0) + @rematch/select (3.0.0 - current) with an older TypeScript version .

And other users could use:

• Rematch + Reselect(>=4.1.0) + @rematch/select (4.0.0 - next)

What do you think? I think is worth it to invest in this, we keep a better development line than RTK.

@NoahStepheno You can read CONTRIBUTING.md how to clone, setup, and work with Rematch codebase. Feel free to ask anything on Discord or here if you feel stuck.

from rematch.

That was great. Yes - It's worth investing in this.

from rematch.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from rematch.