Comments (13)
This issue still exist :< It is a pity that this continues
from rematch.
Test looks good, though I'll see how I can extract the problem from my (admittedly large) repo onto a reproducible one.
from rematch.
Hello,
I've come across another issue using immer plugin which is fixed in the lates version. So I'm stuck between these 2 issues.
I've extracted a reproduction from my project here:
https://codesandbox.io/s/rematch-typescript-bug-b47q22?file=/src/App.tsx
Hope this helps fixing this one.
from rematch.
We'll look into it, as soon as possible. Thx for reporting this out, I thought we had an scenario of this on our testing suite.
from rematch.
Can't reproduce the issue with this test mate:
it('reducer without any argument', () => {
const model = createModel<RootModel>()({
state: 0,
reducers: {
inc(state) {
return state
},
},
})
interface RootModel extends Models<RootModel> {
myModel: typeof model
}
const store = init({ models: { myModel: model } })
const { dispatch } = store
dispatch.myModel.inc()
// @ts-expect-error
dispatch.myModel.inc(1)
})
Could you provide a sandbox?
from rematch.
1066936
Just pushed a commit to check against CI.
from rematch.
I'm finding the same trouble on 2.2.0 and not on 2.0.1 but not with a reducer but with a parameter-less effect.
from rematch.
I'm finding the same trouble on 2.2.0 and not on 2.0.1 but not with a reducer but with a parameter-less effect.
Hey Javi! Isn't this test
what you're doing/using?I'm open to help if i can reproduce it somehow
from rematch.
I recently ported my project from next.js to create-react-app. Strangely this issue is happening only in create-react-app for me.
I had to downgrade to v2.0.1
from rematch.
Do you use any plugins? or something we can use to reproduce it?
from rematch.
I have the same issue, probably caused by a similar bug in the argument typing calculation:
(property) setMark: (payload: any, meta: any) => any
Expected 2 arguments, but got 1.
my code:
dispatch.chartEditor.setMark("point")
I believe the reason is because I didn't have an effects
entry in that particular model. When I added one (effects: (dispatch) => ({})
or effects: {}
), the error goes away.
from rematch.
I have the same issue, probably caused by a similar bug in the argument typing calculation:
(property) setMark: (payload: any, meta: any) => any Expected 2 arguments, but got 1.
my code:
dispatch.chartEditor.setMark("point")I believe the reason is because I didn't have an
effects
entry in that particular model. When I added one (effects: (dispatch) => ({})
oreffects: {}
), the error goes away.
Our testing suite of typings, tests that scenario, so I guess it should be something else.
from rematch.
This issue happens when I build my project on nextjs but not on my vscode. Something really weird is happening.
from rematch.
Related Issues (20)
- Arguments Conflict with TS HOT 7
- What shall we put as the second generic type of RematchStore<TModels, TExtraModels> HOT 2
- Effects in custom middleware HOT 3
- Type errors when calling effects which utilize rootState without needing a payload HOT 4
- Preserving Rematch.js state between server and client side in Nextjs HOT 1
- @rematch/select typing problem with createSelector() function
- [Typescript] Faulty types HOT 2
- `RematchRootState` second argument default of `Record<string, never>` generates useless state type HOT 1
- @rematch/core has incompatible types with react-redux@8
- TS error while using selectors inside model effects (with plugin like loading) HOT 1
- [Question] Effects in separate files HOT 1
- Conditional types omitted in model effect
- Installation step for @rematch/immer installs immer 10 HOT 2
- [Question] Best practice on call this in reducers and get updated state in effects.
- Effect type inference error on typescript 4.9
- Rematch immer compilation error - (imported as 'produce') was not found HOT 8
- Rematch website is down HOT 5
- 使用store返回的dispatch方法修改数组类型页面无法自动更新
- immerPlugin of @rematch/immer doesn't work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rematch.