remarkjs / gulp-remark Goto Github PK

View Code? Open in Web Editor NEW

10.0 10.0 3.0 108 KB

Legacy Gulp plugin for remark — please use npm scripts and the like

Home Page: https://remark.js.org

License: MIT License

JavaScript 100.00%

gulp gulp-plugins markdown remark remark-plugin

gulp-remark's People

Contributors

Stargazers

Watchers

Forkers

silvenon isabella232

gulp-remark's Issues

error on CI

Run in gitlab CI, last version plugin, options standard (from example).

[10:52:19] Error: remark does not accept both files and stdin
    at Ware.stdin (/tmp/wordpress/src/wp-content/themes/insteria/node_modules/gulp-remark/node_modules/remark/lib/cli/file-set-pipeline/stdin.js:50:19)
    at Ware.<anonymous> (/tmp/wordpress/src/wp-content/themes/insteria/node_modules/gulp-remark/node_modules/remark/node_modules/ware/node_modules/wrap-fn/index.js:45:19)
    at next (/tmp/wordpress/src/wp-content/themes/insteria/node_modules/gulp-remark/node_modules/remark/node_modules/ware/lib/index.js:85:20)
    at /tmp/wordpress/src/wp-content/themes/insteria/node_modules/gulp-remark/node_modules/remark/node_modules/ware/node_modules/wrap-fn/index.js:121:18
    at next (/tmp/wordpress/src/wp-content/themes/insteria/node_modules/gulp-remark/node_modules/remark/lib/cli/file-set-pipeline/file-system.js:44:13)
    at /tmp/wordpress/src/wp-content/themes/insteria/node_modules/gulp-remark/node_modules/remark/lib/cli/ignore.js:185:13
    at /tmp/wordpress/src/wp-content/themes/insteria/node_modules/gulp-remark/node_modules/remark/node_modules/vfile-find-up/index.js:207:17
    at FSReqWrap.oncomplete (fs.js:82:15)

An in-range update of babel-eslint is breaking the build 🚨

Version 7.2.1 of babel-eslint just got published.

Branch	Build failing 🚨
Dependency	babel-eslint
Current Version	7.2.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As babel-eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 6 commits .

3cda62e 7.2.1
5626de1 Remove left over eslint 2 estraverse code (#452)
b5fb53b Fix type param and interface declaration scoping (#449)
f1cee0f Remove lodash dependency (#450)
eb05812 Format non-regression errors for legibility (#451)
7972a05 Update README.md with codeFrame option (#448)

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

add failOnError and failAfterError for lint

As in eslint:
https://github.com/adametry/gulp-eslint#eslintfailonerror
https://github.com/adametry/gulp-eslint#eslintfailaftererror

frail not working with `gulpRemark().use(plugin[, options])`

.pipe(gulpRemark({detectRC: false, frail: true}).use(gulpRemarkLint, config.options.remarkLint));

`options.detectRC` not working

@denysdovhan
Always true https://github.com/denysdovhan/gulp-remark/blob/master/index.js#L15

'use strict';

var options = require('../options');
var taskConfig = options.get('tasks.remarkLint');

if (!taskConfig.enable) {
    return;
}

var gulp = require('gulp');
var gulpPlumber = require('gulp-plumber');
var gulpRemark = require('gulp-remark');
var gulpRemarkLint = require('remark-lint');
var definingConfiguration = require('../lib/defining-configuration');

function remarkLintTask() {
    var config = this.config;

    return gulp
        .src(config.paths.src.globs, config.paths.src.options)
        .pipe(gulpPlumber(config.options.plumber))
        .pipe(gulpRemark({detectRC: false})/*.use(gulpRemarkLint, config.options.remarkLint)*/);
}

gulp.task('remarkLint', definingConfiguration(taskConfig, remarkLintTask));

module.exports = remarkLintTask;

{
    "plugins": {
        "lint": {
            "external": [],
            "reset": false,
            "blockquote-indentation": 4,
            "checkbox-character-style": {
                "checked": "x",
                "unchecked": " "
            }
        }
    }
}

.remarkrc loaded and runs all plugins.

bug with options and double run

remark().use(lint)

.remarkrc

"plugins": {
        "lint": {
            "list-item-indent": "space"
        }
}

First use remark() use .remarkrc and run lint plugin, second use double run lint plugin, but not get config file .remarkrc

bug: remove rcName from config (otherwise detectConfig not used)

Initial checklist

I read the support docs
I read the contributing guide
I agree to follow the code of conduct
I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

latest

Link to runnable example

No response

Steps to reproduce

Either we need to remove

gulp-remark/index.js

Lines 9 to 10 in b856c01

 rcName: '.remarkrc', 

 ignoreName: '.remarkignore'

or set detectConfig to true.

https://github.com/unifiedjs/unified-engine-gulp#optionsdetectconfig

Expected behavior

It should detect config if you don't have the same value as default rcName of .remarkrc for your config.

Actual behavior

Custom config files with different names don't load

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

`option.frail` not working

@denysdovhan
#5 (comment)

Gulp not exit with code > 0

'use strict';

var options = require('../options');
var taskConfig = options.get('tasks.remarkLint');

if (!taskConfig.enable) {
    return;
}

var gulp = require('gulp');
var gulpPlumber = require('gulp-plumber');
var gulpRemark = require('gulp-remark');
var gulpRemarkLint = require('remark-lint');
var definingConfiguration = require('../lib/defining-configuration');
var path = require('path');
var fs = require('fs');
var remarkLintOptions = JSON.parse(fs.readFileSync(path.join(process.cwd(), '.remarkrc'), 'utf8'));

function remarkLintTask() {
    var config = this.config;

    return gulp
        .src(config.paths.src.globs, config.paths.src.options)
        .pipe(gulpPlumber(config.options.plumber))
        .pipe(gulpRemark({detectRC: false, frail: true}).use(gulpRemarkLint, remarkLintOptions.plugins.lint));
}

gulp.task('remarkLint', definingConfiguration(taskConfig, remarkLintTask));

module.exports = remarkLintTask;

Output:

/some/path/to/README.md
       27:3  warning  Incorrect indentation before bullet: remove 2 spaces  list-item-bullet-indent
       27:3  warning  Incorrect indentation before bullet: remove 2 spaces  list-item-bullet-indent

⚠ 2 warnings
[18:45:21] Finished 'remarkLint' after 7.03 s

remarkjs / gulp-remark Goto Github PK

gulp-remark's People

Contributors

Stargazers

Watchers

Forkers

gulp-remark's Issues

Version 7.2.1 of babel-eslint just got published.

Initial checklist

Affected packages and versions

Link to runnable example

Steps to reproduce

Expected behavior

Actual behavior

Runtime

Package manager

OS

Build and bundle tools

Recommend Projects

Recommend Topics

Recommend Org