reiven / tomber Goto Github PK

Here an awesome logo for tomber

Made by Logan VanCuren on his attempts to write ptomb.

As of now I think tomber is the best py hook since its a wrapper, I would not recommend rewriting all tomb in python for maintainability issues (we better all depend from the same shell script).

ciao

It seems like the tomb option --unsecure-dev-mode has been changed to --unsafe in recent versions. (Or they're are different options altogether?)

In any case, --unsecure-dev-mode is not a valid option for the forge command in Tomb v2.2.

This is blocking some basic Tomber functionality such as the tforge function.

Not sure if this is exactly what is going on here, but I suspect replacing all instances of --unsecure-dev-mode with --unsafe in Tomber would resolve this. But would definitely break backwards compatibility. Again, not sure what versions of Tomb are in play here.

Hi,

You should use Popen by giving it a list of arguments instead of a single string:

# good
Popen(['tomb', 'slam'])

# bad, see the warning at https://docs.python.org/2/library/subprocess.html#index-2
Popen('tomb slam', shell=True)

This way you will avoid security issues and you wont need functions like sanitize_passphrase and the use of ' '.join()

Best regards.

Hello,

There are a few typos and grammatical errors in the README.mkdn file. I have forked the project and will fix those issues for you.