reitzig / actions-asciidoctor Goto Github PK

Repetition stinks. Currently, every user has to repeat the call to ruby/setup-ruby; we should do that for them.

Once ruby/setup-ruby#58 is done, adopt the solution here.

Using reitzig/[email protected] produces the following warning:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: reitzig/[email protected]. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The installation fails because of GitHub actions deprecating 'set-env' and 'add-path' commands.

Error: Unable to process command '::add-path::' successfully.
Error: The add-path command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

add-env in:

set-env in:

This whole action really comes from the need not only separately installing, but also hacking additional parameters into calls when using Hugo:

• https://discourse.gohugo.io/t/customize-asciidoctor-parameters/14440/3
• gohugoio/hugo#5842
• gohugoio/hugo#7281

Once Hugo allows to configure its use of asciidoc(tor), this motivation goes away.

• Remove the wrapping of asciidoctor
• Re-evaluate whether there's a use case left for this action, or if a straight-forward gem install isn't the preferable approach.

When used in tandem with https://github.com/peaceiris/actions-hugo, calls to asciidoctor from Hugo fail:

/home/runner/work/today-i-learned/today-i-learned/actions_asciidoctor/asciidoctor rendering posts/2020-04-24-navigating-slack.adoc: fork/exec /home/runner/work/today-i-learned/today-i-learned/actions_asciidoctor/asciidoctor: exec format error

Not sure what the qualitative difference to the old hack on that end is, though.