reinhrst / abstractcp Goto Github PK

Take this example:

class A(abstractcp.Abstract):
    NAME: str = abstractcp.abstract_class_property(str)


class B(A, abstractcp.Abstract):
    NAME = 'class B'


class C(B):
    NAME = 'class C'

If B inherits Abstract you get the error that an abstract property is required. If B does not inherit Abstract you naturally get the problem that it doesn't inherit Abstract and doesn't implement NAME

Hi there,

Is it possible to have a class which derives from both abstractcp.Abstract and the builtin abc.ABC? I would like to be able to define a base class which has both abstract class properties AND abstract methods that subclasses must override. Right now doing something along the lines of:

from abc import ABC, abstractmethod
from abstractcp import Abstract, abstract_class_property

class BaseClass(ABC, Abstract):
    foo = abstract_class_property(str)

    @abstractmethod
    def bar(self):
        pass

class SubClass(BaseClass):
    foo = "string"
    
    def bar(self):
        print("In bar")

causes an error on startup:

.../python3.8/site-packages/abstractcp/__init__.py:98: in __init_subclass__
    if isinstance(getattr(cls, name), _AbstractClassProperty):
E   AttributeError: __abstractmethods__

and removing ABC means an exception is no longer raised if the subclass does not implement the abstract method.

Any help would be appreciated, thanks!