Giter Club home page Giter Club logo

popular_movies's People

Contributors

regardts avatar

Watchers

 avatar  avatar

popular_movies's Issues

My 2 cents

Detail.java

  • line 52-53, variable names.
  • line 55, you're using "test". I suggest creating a class/enum with for storing keys you use for your bundles.
public enum BundleExtras{

    TEST("test")

    private final String name;       

    private Modes(String someName) {
        name = someName;
    }

    @Override
    public String toString(){
        return name;
    }
}

(i don't know how to phrase this properly in english, so askies beforehand :-) )
This will mean that if you were to change the value "test" only on one side, you'll know before
you compile thus preventing a subtle error like the following:

Putting:
b.putSerializable("test",tempMovie);

Getting:
currentMovie = (Movie) getIntent().getSerializableExtra("newTest");

  • line 86: No error handling?
  • line 92: method name is bad and you should feel bad. #zoidberg
  • Detail.java to DetailActivity.java?

MainActivity.java:

  • no error handling in line 108.
  • Tightcoupled! You need to "program to interfaces". You should be able to
    change the image loader without touching this activity. You need to inject the
    image loader as a dependency. The same thing sort of applies to the library you're using for a rest api. Retrofit and Picasso are tightly coupled!
    Consider looking at this answer highlighting why its important to program to interfaces: http://stackoverflow.com/a/384067/1984350

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.