regaez / moodle-local_sidebar_contact Goto Github PK

The following code in js/scripts.js is not correct:

var ajaxURL = window.location.origin + '/local/sidebar_contact/index.php';

If the Moodle instance is running in a subdirectory of the webserver, it produces invalid URL. Ideally, this URL should be passed directly from the PHP. This is easy with YUI, not that easy with jQuery in Moodle framework.

As I can see, the JS function isEmail(email) is defined in the global scope. Why not to have it inside your closure?

The current code for including your js/scripts.js in lib.php is overcomplicated. It can be easily written in more safe way as

$PAGE->requires->js('/local/sidebar_contact/js/scripts.js');