ref-finance / ref-ui Goto Github PK

Overview

With the implementation of #97, the "Deposit" page is no longer necessary. Instead, this page should function as an "Account" page, which shows the user's active balances (they can still withdraw), LP positions, and swap history

Acceptance Criteria

• "Deposit" is renamed "Account"
• Users can view their balances in Ref and withdraw
• Active LP positions are displayed
• Swap history is displayed

Overview

We should implement ref-finance/ref-contracts#30. This way, users will not need to deposit before swapping. Additionally, we will need to refactor the "Deposit" page, as it is no longer relevant.

Acceptance Criteria

• Users can swap tokens without depositing
• If the user is swapping for an unregistered token, the token is first registered
• Users can add liquidity without depositing

For example: https://explorer.near.org/transactions/CCQbe9fpTFrqW1YnCbi725oA3ZDZtKHGjwaTeRWHUvfQ

If exchange is not registered in the token, the error is very unclear. Potentially UI should suggest user to register the exchange in the token when user registering this token in the exchange.

Context: for exchange to receive new token, the exchange must be registered on the token contract (deposit 0.0125N) to prevent storage blowup

Overview

The skyward team has developed contracts that can be used for an airdrop claim. We need a page for users to call the claim function to retrieve their $REF.

Acceptance Criteria

• Logged in users can view their $REF airdrop balance (using the get_account function)
• Users with a > 0 balance can click "Claim", and receive their $REF after authorizing the transaction

Currently, when logging in for the first time user is asked to make initial deposit for account storage...

A more ideal flow would be to combine this with the users first deposit. We should always show if more storage deposit is required and bundle that transaction call (which we are already doing): “Extra 0.01 N will be deposited to cover storage. You can withdraw it later. Read here about storage deposits for Ref Finance.” (edited)

Overview

On the /pools page, we should remove the "Total Shares", add "Market Price", and show the totals of each token.

Acceptance Criteria

• For each pool, the total # of each token in the pool is shown under "Liquidity" (see image below)
• For each pool, the "Market Price" is shown (see calculation)
• "Total Shares" isn't shown

Calculating Market Price
If the pool is nDAI - wNEAR

• 10,000 DAI
• 2,000 wNEAR

Market price = 10000 / 2000  = 5 nDAI

CoinGecko Price API: https://www.coingecko.com/api/documentations/v3

May be have a "wrap" with more - and allow to unregister those tokens if user wants.

Overview

Let's display the following for each farm card:

When user hasn't staked

• Rewards per week
• APR
• Total Staked (in NEAR)

When user has staked

• Your Shares
• APR
• Total Staked (in NEAR)
• Unclaimed Rewards

Total Staked calculation
If the pair is BANANA <> NEAR, and there are 3000 BANANA to 500 NEAR, display 500 NEAR

APR Calculation
( (1/Total Shares Staked) * (Rewards per week * price of reward token) * 52 ) * 100)

To get the price of the reward token, get the market price in wNEAR and multiply by the USD price of NEAR from CoinGecko API

Overview

Once #97 is implemented, there is no reason to have both "Claim" and "Withdraw" actions in Farming. Instead, there should be one button "Claim", which should both claim the tokens on the user's behalf, and withdraw them.

Acceptance Criteria

• There is no "Withdraw" button
• Selecting the "Claim" button for a specific farm claims and withdraws the tokens to the user's account
• Remove "Claim" from the side menu, so users must claim each token individual

make adboard available for all funcions

Overview

Feedbacks on UI:

• Definitely need to show the account id for the token traded everywhere. Right now there is "SKY" token with the same icon which is not SKYWARD token but people will be confused
• Please add a space in after ":" in "Balance:0" on Swap page and in adding liquidity/deposits.
• Swap screen should default to exchanging 1 NEAR to DAI - e.g. have default 1 entered if there is nothing entered in the Swap screen - even if it's not logged in. This way one can see the everything in action and as they switch tokens they also see the price.
• Let's show not just Swap rate but Buy and Sell rate (e.g. both ways). And have ~$ amounts under it.
• Say somewhere after the swap that need to withdraw to see it in the wallet.
• In "View Pools": it right away shows "No more pools" and only then loading screen. Please just show loading screen right away.
• In View Pools TVL column doesn't have "," separators in the numbers
• Generally I find the Liquidity and Market price a bit confusing. But I don't have a good suggestion how to improve it. Market Price is def a confusing name there too, as this is specific pool's price vs global market price which I would expect. Not sure if we need to show this pool info there. Yield/APR when they are available def a better use of the space.
• Going into Pool details: Total liquidity is missing, even though it's shown in "View Pools" (TVL). Really need to show the token addresses here (with links to explorer).
• Change "Rainbow Bridge" at the top to "Move assets to/from Ethereum" and may be just an icon of rainbow.
• When i click double in max its directly send me to swap even i dont click in swap.

Overview

On the /deposit page, if the user has a balance of 0 on their account for a selected token, the "Deposit to Stake" button should be inactive.

Overview

Add titles: "Pair" and "Shares Owned" to the table

Overview

On the /swaps page, if the user has a 0 balance of the base token in Ref, the button should say "Deposit". After clicking this button, the user should be redirected to /deposit

For example, see the current implementation on https://app.ref.finance. Instead of being inactive, the button should be clickable and redirect.

Long account addresses display undefined at the end.

People are confused on how to wrap / unwrap NEAR and should be more visible.

Solution:

• have deposit default to Ⓝ token and when depositing Ⓝ auto wrap _and_deposit.
• have withdraw default to Ⓝ and auto unwrap and withdraw

Steps:

1. go to https://testnet.ref.finance/
2. login
3. go to https://testnet.ref.finance/portfolio
4. Click "Withdrawal"
5. Observe error:

errors.js:18 Uncaught (in promise) Error: Querying call/NEAR/ft_balance_of,DHcDMR9nKJkkBNH6cvhy24vc6cHXs8TGTnHb5uceES69DSHS failed: Contract ID "NEAR" is not valid.
{
  "error": "Contract ID \"NEAR\" is not valid",
  "logs": [],
  "block_height": 43224406,
  "block_hash": "ERk7whDDfKk4TRR9T5BTYTpHFXE79QiqVRmyd9F7D4QZ"
}
    at f.query (json-rpc-provider.js:80)
    at async r.viewFunction (account.js:271)

Overview

Add the UI for the farming contracts: ref-finance/ref-contracts#3

Overview

Implement the mobile views from the designs, and make the other views scale to smaller screen sizes.

https://www.figma.com/file/fuv8rWM8NGxKUKw2OAFsbn/Ref.Finance?node-id=134%3A1

Currently users keep adding new pools (and can't see them).

Show existing pools for given two tokens when adding new pool, to avoid people adding new ones and instead provide liquidity.

There should be also a message that says that it's better to provide liquidity to existing pool instead of adding new one. Probably people are confused that adding pool is not providing liquidity.

Users need clarification on many parts of the app. Tool tips need to be added to explain:

Porfolio

• deposit / withdraw
• deposit NEAR actually wraps and deposits
• withdraw NEAR actually unwraps and withdraws
• whitelist token
• balances only reflect deposited balances

Swap

• what is slippage?
• what is a swap?

Pools

• add liquidity
• remove liquidity
• add liquidity pool
• what is register token?

Overview

Clicking "Connect to NEAR" on the navbar doesn't redirect. The "Connect to NEAR" button on the /swaps page is implemented correctly

Overview

Swap page todo list:

Feature List:

• A button to display the price reverted on swap page
• Refresh the price on swap page every x seconds to avoid slippage errors
• Keep slippage setting after doing a trade

Bug List:

• Sometimes when typing the prices don't load correctly (probably cause old requests are answered with delay)
• When doing two trades in a row, trading pairs are reset to default
• When add liquidity or do swap action, use ft_metadata to check token id is right.

Overview

Implement the new fonts, backgrounds, colors, and UI elements in these designs: https://www.figma.com/file/fuv8rWM8NGxKUKw2OAFsbn/Ref.Finance?node-id=134%3A1

This is my code with 18 decimals

fn ft_metadata(&self) -> FungibleTokenMetadata {
FungibleTokenMetadata {
spec: FT_METADATA_SPEC.to_string(),
name: String::from("Avrit fungible token"),
symbol: String::from("AVRIT"),
icon: None,
reference: None,
reference_hash: None,
decimals: 18,
}
}

1×10^25 should show 1*10^7 tokens, but ref finance shows 1×10^19. Am I doing everything right?

Overview

There is a 0.05% fee added to all pools (which goes to the protocol). Currently, users don't realize this fee is included, and their fees end up being higher than they expect. We should make this clear to users upfront.

Acceptance Criteria

• The total fee is shown on the /pools/add page, including the 0.05% fee
• It is explained to users that 0.05% is added to the fee they select
• The default is 0.25

Lots of users think their funds are "missing" when trying to swap non-deposited assets, could be easily avoided by adding a CTA pointing to the deposit view

README for this project needs to be updated for new developers to onboard

If I hit the MAX button in swap, the numbers are off and I get an error when trying to initalize the transaction.

requesting the transfer of
Ⓝ
9.99801
Available Balance: Ⓝ
9.99508

Sorry an error has occurred. You may want to try again.
Error: Sender mikey.near does not have enough balance 9995384510879566600000000 for operation costing 10038268808077530345929833

In the picture When I move the page a bit it shows like this.

Overview

We currently have over 1000 liquidity pools (almost as many as the number of users!). To make it easier for users to pick a pool for a given pair (e.g. nDAI <> NEAR), we should display only the most liquid pool per pair.

Additionally, we should sort by the most liquid token pairs. So if nUSDT <> wNEAR is most liquid, it should be the first displayed.

Acceptance Criteria

• For each pair, only one pool is displayed in the list and in search
• The most liquid pool is displayed per pair
• If a pool has farming rewards, this is indicated next to it in the list
• The list is sorted by the most liquid pairs

Overview

Implement the "Your Liquidity" page from the designs. This page will show the user's active LP positions.

Designs: https://www.figma.com/file/fuv8rWM8NGxKUKw2OAFsbn/Ref.Finance?node-id=710%3A65

Acceptance Criteria

• "Your Liquidity" is the top choice in the "Pools" dropdown
• All of the users LP positions are shown
• Selecting "Add Liquidity" takes the user to the /pools page

Overview

We should hide the "n" from tokens like nETH that are whitelisted, and instead just show "ETH". Several users have reported this as confusing, and it benefits Ref if users feel like they are using "real ETH".

Acceptance

• For tokens on the whitelist, the "n" is parsed and doesn't appear (nETH shows as ETH)
• wNEAR is displayed as NEAR

Overview

To better promote the earning opportunities for LPs, we should show the historical fee totals for LPs.

Currently it only shows first X pools but doesn't have pages.

currently the withdraw method unwraps wNear first, then withdraws it from the exchange, however some users need their wNear for other applications so it's useful to allow direct wNear withdrawals and save them the hassle of wrapping it all over again.

Overview

The current implementation of the "Your Liquidity" page requires 1000+ RPC calls to load all LP positions. It should instead use the Indexer to keep track of these positions.

Acceptance Criteria

• An instance of the indexer is running for Ref
• The instance indexes the following for the ref-finance.near account
  • add_liquidity calls for each pool_id and account
  • remove_liquidity calls for each pool_id and account
• The pools a given account has provided liquidity too, and the current totals can be returned and displayed

This project has not yet been audited and user needs to be informed of this.

A banner of “Community developed. Not audited. Use at your risk.” should be added to swap screen

Add URL for selected markets to swap. Ex. https://app.ref.finance/swap#nusd-wnear

Overview

Users should be able to claim and withdraw their farming rewards with a single clickl

currently this Icon is used per default for Tokens with no Icon assigned to them (Exp: nComp). However that same Icon is used by Pulse for wNear, which might confuse some users.
It'd be better to use another Icon that indicates clearly that it's a placeholder, and won't be confused for something else.

some images use 'https://imgur.com/' storage. the website is blocked in china by GFW. please fix it.

I have another question，Why use https://coinmarketcap.com/ website image?

Currently, the UI is like this.

It needs to be improved ASAP for better UX

Currently, you can create fake tokens, we should prevent users from trading scam tokens.