reez / bitcoinui Goto Github PK

Is your feature request related to a problem? Please describe.
Support only iOS 16+17

Describe the solution you'd like
Change Package.swift

Describe the bug
Replace any swiftui color with the bitcoin color... I might have missed a few while building out some screens.

Hi, I've been involved in the Bitcoin Design community since the start and am currently trying to build an open source 'daily spending wallet' based on the same concept in the Bitcoin Design Guide. Some of my work so far can be found here.

I am going to try to emulate the UI components as closely as possible, and this repo is a good start with the colors and icons files.
The examples are also useful, but what I am hoping to do is break those screens down to individual components that can be available in a 'components.swift' file, alongside the colors and icons files.

A couple of questions on the setup of the repo:

• What files are included in the package library imported to an app that uses this repo, only the colors and icons files?
• If I add a new 'components.swift file', will that automatically get included in the package or do I need to specify that somewhere?

Let me know if you have any other thoughts on what I'm trying to do.

Is your feature request related to a problem? Please describe.
I downloaded the assets from main but didn't see a bitcoin.svg in the outline folder.

Describe the solution you'd like
Add bitcoin-outline when it is in https://github.com/BitcoinDesign/Bitcoin-Icons assets.

Describe the bug
make sure all button corners are rounded... I might have missed a few while building out some screens.

Is your feature request related to a problem? Please describe.
WalletUI includes everything in the MyMattress flow, except "Coldcard import" previews.

Describe the solution you'd like
Reference Figma to implement "Coldcard import" flows.

(Likely can re-use a lot of the screens already created)

Is your feature request related to a problem? Please describe.
Changes made to Figma file on October 15, 2021

Describe the solution you'd like
Update to match Figma file changes

Additional context
Figma

Is your feature request related to a problem? Please describe.
Need to add the coldcard 75 icon from Figma reference file

Describe the solution you'd like
Im not a good enough designer, so I couldn't get the coldcard 75 icon to properly export for me like the rest of the icons.

Is your feature request related to a problem? Please describe.
I downloaded the assets from main but didn't see a node.svg in the outline folder.

Describe the solution you'd like
Add node-outline when it is in https://github.com/BitcoinDesign/Bitcoin-Icons assets.

Is your feature request related to a problem? Please describe.
iOS platform has Dynamic Type for use instead of ascribing a specific point size HIG

Describe the solution you'd like
Match HIG Dynamic Type with Figma file fonts

Describe alternatives you've considered

Additional context

Change the name of the repo/package to align with other sister projects: BitcoinDesign/Guide#1024 (comment)

Is your feature request related to a problem? Please describe.
Apple has SF Symbols available HIG

Describe the solution you'd like
Mix and match use of SF Symbols with Figma file icons

Additional context
SF Symbols provides a set of over 2,400 consistent, highly configurable symbols you can use in your app. Apple designed SF Symbols to integrate seamlessly with the San Francisco system font, so the symbols automatically ensure optical vertical alignment with text in all weights and sizes

Is your feature request related to a problem? Please describe.
Changes made to Figma file on October 15, 2021

Describe the solution you'd like
Update to match Figma file changes

Additional context
Figma

Is your feature request related to a problem? Please describe.
Changes made to Figma file on March 24, 2022

Describe the solution you'd like
Update to match Figma file changes

Additional context
Figma
"Overall clean-up and addition/revision of screens for contacts, activity, send, and more."

Is your feature request related to a problem? Please describe.
WalletUI should support both light+dark mode.

Describe the solution you'd like
Implement the dark mode colors in the color extension.

Additional context
Just need to get the dark mode colors, will implement the color extension with getting these colors in mind.

Describe the solution you'd like

Remove any duplicate icons.

If there are icons imported from Figma that are already in SF Symbols, use the SF Symbols icon, remove the Figma icon from WalletUI resources.

So for example, the standard settings-like “gear” icon is available in SF Symbols so can remove the Figma icon that was imported into WalletUI.

Additional context
#4

Is your feature request related to a problem? Please describe.
Bitcoin Icons and Hardware illustrations have been updated and added GitHub repos.

Describe the solution you'd like
Use the GitHub repos
https://github.com/GBKS/bitcoin-hardware-illustrations
https://github.com/BitcoinDesign/Bitcoin-Icons

Additional context

• Do I need to remove a layer on all new icons like I did with Figma files?
• Remove old bitcoin icons
• Remove old hardware icons
• Add new bitcoin icons
• Add new hardware icons
• Make sure Previews still work (old icons had 3 sizes, make sure to constrain Image size now)
• Make sure MyMattress still works (dot icons might not be in bitcoin/hardware icons)

Rectangle buttons existed but I just added Capsule buttons (which I hope is a nice addition), what do you think about me renaming the Rectangle buttons?

I named the capsule buttons BitcoinCapsuleFilled and BitcoinCapsuleOutlined with the Rectangle buttons in mind so that I could possibly rename those to BitcoinRectangleFilled and BitcoinRectangleOutlined possibly. Thoughts @danielnordh ?

Also I didn't make a BitcoinCapsulePlain button because BitcoinPlain doesn't really have a border shape anyway from what I can tell, let me know if I'm missing something though.

Is your feature request related to a problem? Please describe.
See #4 discussion for solution on icon mix.

Describe the solution you'd like
remove any unused icons

Is your feature request related to a problem? Please describe.
If under Swift5.9/iOS17/Xcode15 Previews may not render correctly since BitcoinUI moved to only having the newest version of Previews #Preview.

Describe the solution you'd like
Add back QRCodeView_Previews: PreviewProvider while keeping the new #Preview as well.

Additional context
Mentioned by user in reez/Monday#56

Is your feature request related to a problem? Please describe.
Changes made to Figma file on February 3, 2022

Describe the solution you'd like
Update to match Figma file changes

Additional context
Figma
"Clean-up & tweaks for more awesomeness."