Giter Club home page Giter Club logo

Comments (20)

andrerpena avatar andrerpena commented on May 23, 2024 2

Hey @JonatanSalas and @danigomez , I just thought about it thoroughly and the conclusion I got to is that we should not try to have separate branches for the demo, neither have a single unified demo. Here is why:

  • Having the demo together with the UI itself doesn't mean we publish it to NPM. The NPM package has no demo at all, which means no footprint, or no overhead to the user of the library
  • Having the demo together with the UI reduces the effort for debugging. If we use this "submodule" thing, we're adding overhead to the newcomers. The simpler we get, the bigger the chance we have contributors
  • Having demos for multiple UI together will certainly lead to conflicting CSS (Bootstrap vs Material competing). LESS and SaSS have means of "isolating" CSS but the time I tried to make this work, I got into some troubles that I really think it's a waste of time.
  • I already have the demo here bootstrap project.. And that took me time.
  • What we can do, indeed, is to separate demo functionalities in a separate project to reduce duplication.

Any comments? Or can we do it that way? I really didn't want to spend time with this. I mean.. We should focus. I have a platform to build and a deadline to meet.

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024 2

Perfect job! This is growing faster! :)

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024 1

This is definitely the best way. You can either put the demo on the gh-pages branch of each UI library or you can use that website repo you created.

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024 1

André, really cool! Thank you very much! :)

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024 1

Let's keep it as is, and then when we get more advance on redux-autoform itself, we can try to get a better and simpler way to achieve this! 😄

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024 1

Thanks for the comprehension. I already moved the demo to the bootstrap project and I'm closing this issue as soon as I manage to publish the LIVE demo.

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024 1

Cool andré! We are going to do this things tomorrow! Nice work! :)

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024

@andrerpena Okey, I will work on the migration of the demo too.

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024

I'll moving the demo right now.

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024

Okay, thanks andré! Excuse me, I have no time to move it yesterday! :/

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024

@JonatanSalas don't worry. It's done and working. I'm just organizing the dependencies that are now useless and I'll publish this today.

from redux-autoform.

danigomez avatar danigomez commented on May 23, 2024

Hi @andrerpena , we were thinking with Joni how to solve the two points, have the demo in other branch and also allow you to work with hot reload.
Our proposal is to create a new repo with all the UI modules as submodels, in this way when you clone the demo all the git repos of all the UIs that are submodules will be downloaded and the hot reload will be possible.
Also we want to add a combo in the demo to select which UI you want to test, this way is possible to switch from UI to UI. what do you think???

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024

I like the unified demo thing.

I just didn't understand how can I "work" on the components and at the same time have the demo to hot-load.. Can you elaborate?

from redux-autoform.

danigomez avatar danigomez commented on May 23, 2024

What i mean is to have a repo, say, redux-autoform-demo which will have as git submodule redux-autoform-bootstrap-ui, redux-autoform-material-ui, etc, Because the git submodule downloads the code of the other repos as submodule, when you clone the redux-autoform-demo it will also download all the code of the UIs and then the demo will still working as is, but with te UI code in other repos. We will create a POC to check if is really possible but that's the idea 😄

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024

Oh now I understand. Yes..please create a POC because this seems weird. I mean.. I use WebStorm and it has pull push features. I don't know if it supports submodules.. I mean.. Now it would have to ask me which repo I'm talking about when I hit push.

The idea is neat but should be tested. I don't think I've seen it elsewhere.

Thank you.

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024

Excuse us! There is no trouble 😄

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024

I got to publish the demo here: https://redux-autoform.github.io/redux-autoform-bootstrap-ui/demo.html

Things that still need to be done:

  • Remove the demo from the RAF source project
  • Remove the demo from the RAF gh-pages
  • Update documentation

Really.. any help is appreciated :)

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024

What pushed me back was that god damn bug with the localizer and I coudn't publish it without solving it. It's over now. Thank you.

from redux-autoform.

JonatanSalas avatar JonatanSalas commented on May 23, 2024

@andrerpena I only have to make an update on the documentation.

from redux-autoform.

andrerpena avatar andrerpena commented on May 23, 2024

Demo is now fine, documentation should be the problem now: #45

from redux-autoform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.