Comments (9)
I will take a look at it! Thank you!
from redux-autoform.
Thanks for reporting
from redux-autoform.
@JonatanSalas Checking in to see if there is any estimate by when this bug would be resolved?
from redux-autoform.
I will take a look this weekend. Because this week I'm with a lot of work :/
from redux-autoform.
Just FYI, the issue is that the following code is being triggered with 0 float value. Not sure why.
https://github.com/redux-autoform/redux-autoform-utils/blob/master/src/localization/numbroLocalizer.js#L18
from redux-autoform.
OMG.. Good catch. Those should be ===. I didn't analyze it further but
that's what I think at first sight. Can someone send a PR?
Em 21 de set de 2016 10:04 AM, "devang-kredx" [email protected]
escreveu:
Just FYI, the issue is that the following code is being triggered with 0
float value. Not sure why.
https://github.com/redux-autoform/redux-autoform-utils/
blob/master/src/localization/numbroLocalizer.js#L18β
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#91 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABghdSsqWwEvtp69AFKnkCOLd-GLgXiRks5qsStAgaJpZM4J9503
.
from redux-autoform.
Looks like its already fixed in autoforms-utils. Anything needs to be
changed in react-autoform to pick this fix?
On Wed, Sep 21, 2016 at 6:42 PM AndrΓ© Pena [email protected] wrote:
OMG.. Good catch. Those should be ===. I didn't analyze it further but
that's what I think at first sight. Can someone send a PR?Em 21 de set de 2016 10:04 AM, "devang-kredx" [email protected]
escreveu:Just FYI, the issue is that the following code is being triggered with 0
float value. Not sure why.
https://github.com/redux-autoform/redux-autoform-utils/
blob/master/src/localization/numbroLocalizer.js#L18β
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
#91 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABghdSsqWwEvtp69AFKnkCOLd-GLgXiRks5qsStAgaJpZM4J9503.
β
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#91 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARERBEhSA-y1mYc3Hp_-DZimXcvesguRks5qsS0ZgaJpZM4J9503
.
from redux-autoform.
I ended up fixing the line you pointed out. If this is not the only source of the problem, this is surely one.
We need to publish a new version of the utils, update the redux-autoform reference and republish it. I don't know if I'll be able to do it in a timely manner because I got lots of work. But I'll try as soon as I can.
from redux-autoform.
Closed via #96
from redux-autoform.
Related Issues (20)
- Handle required error in ArrayContainer HOT 3
- Research if is possible to migrate all the Metadata validation using AJV HOT 3
- Update to react-redux v5 HOT 3
- dirty or pristine form property HOT 1
- Error: 'model' should be truthy HOT 8
- Redux-AutoForm v1 HOT 1
- Redux Autoform Material UI fails to work HOT 4
- Support text-expressions HOT 8
- Visible fields are not cleared when they become not visible HOT 9
- Add support for visible function on Groups HOT 1
- Fix the demo project HOT 13
- Why is this on experimental state now? HOT 2
- Values are not getting passed to component when redux-form fields are prepopulated HOT 6
- I18n Support HOT 1
- Add refs in every field created in ComponentFactory. HOT 4
- ButtonToolbar should receive more props than submitting? HOT 5
- Issue with Fields HOT 5
- Is there an example of rendering the form with initial values HOT 1
- onBlur is not a function with FieldGroups HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redux-autoform.