Clang error: unused variable 't4' in hlsl++_quaternion.h about hlslpp HOT 6 CLOSED

Yes, I have that pending. The problem is that there are many unused variables that aren't a problem as I only use them to instantiate function and don't use the results. I could create a macro unused_variable or something like that to avoid it. It certainly needs fixing. I'll address this one right away

from hlslpp.

Fixed via 3305152

from hlslpp.

I've made a bug here so you can track it for the future #70 (comment)

from hlslpp.

Thank you! I found this particular error during compilation of my project with HLSL++ 3.3. It was a problem of HLSL++ upgrade to v3.3 because my project is using maximum compilation level. I just want to clarify that I don't really care about unused variables in the unit tests of HLSL++, but it's extremely important to have zero warnings and errors in main headers of the external libraries.

from hlslpp.

Yes, I agree. What I mean is that I cannot promote warnings as errors just yet because there are many false positives that come from the unit tests. I have been a bit careless in that regard. I'll see if I can find some time this weekend to do something about it, or incrementally take care of it. Thanks for your continued help. I've created 3.3.1 in case you feel more comfortable upgrading to releases

from hlslpp.

Thanks! It's really more convenient to upgrade to releases for me since I use CPM.cmake for external library management, which pulls library sources by version/tag.

Btw, if you're building unit tests with C++17 you may use [[maybe_unused]] attribute to ignore those unused variables.

from hlslpp.