Modified metrics should impact score about cvss-v4-calculator HOT 4 CLOSED

I think I do not understand correctly how modified env metric is supposed to be used.
Is either or both assumptions below true?

1. If modified metric is set, then treat non-modified one to be equal to modified for computation purposes.
2. If modified metric is not set, treat the modified one to be equal to non-modified for computation purposes.

from cvss-v4-calculator.

This may be overly simplistic, but the way I think of it is:

AV=$VALUE
if (MAV != X) AV=MAV

etc.

In other words, Modified versions of the Base Metrics completely override the value set for that Base Metric.

And as Jono said, MSI and MSA may have to be handled differently (although conceptually the same way) because there are additional values (S) that do not exist in the SI and SA base metrics.

from cvss-v4-calculator.

I think I understand now. I used the following code instead:

// All other environmental metrics just overwrite base score values,
// so if they’re not defined just use the base score value.
if(Object.keys(this.selectedValues).includes("M" + metric)) {
    modified_selected = this.selectedValues["M" + metric]
    if(modified_selected != "X" && modified_selected != "S") {
        return value == modified_selected
    }
}

from cvss-v4-calculator.

I hope this issues is fixed by 5aa9724 . In case it is not, please let me know.

from cvss-v4-calculator.