Giter Club home page Giter Club logo

Comments (9)

gscottwilson avatar gscottwilson commented on June 21, 2024 1

Had a chance to dive deeper on this and discovered it is indeed a regression due to my refactor. Apologies for the confusion introduced.
The 5.9 was a red herring and 6.1 was correct.
I’ve resolved the issue and sending a PR for your review.

from cvss-v4-calculator.

pandatix avatar pandatix commented on June 21, 2024

This looks like a regression, my Go implem computes 6.1 too :/
I'll try to find where the source and post updates soon.

EDIT: had an emergency to handle...

from cvss-v4-calculator.

skontar avatar skontar commented on June 21, 2024

Could be regression in #52 .

from cvss-v4-calculator.

skontar avatar skontar commented on June 21, 2024

Yep, it is there.

from cvss-v4-calculator.

skontar avatar skontar commented on June 21, 2024

@gscottwilson , can you please have look?

from cvss-v4-calculator.

skontar avatar skontar commented on June 21, 2024

Commit 266c4f6 gives 6.1.

from cvss-v4-calculator.

gscottwilson avatar gscottwilson commented on June 21, 2024

Looks like the unrounded score in this case is 5.941666666666666 so the redhat calculator is correctly rounding to 5.9 and the FIRST calculator as deployed is incorrect at 6.1

from cvss-v4-calculator.

skontar avatar skontar commented on June 21, 2024

Unfortunately, rounding was not figured out yet by the SIG, so it is hard to tell which is right and which is wrong. However, I am unsure how 5.941666666666666 could incorrectly be rounded to 6.1, I would expect 6.0?

Anyway, I have a colleague who may have some time to tackle rounding issues for good somewhat soon™.

from cvss-v4-calculator.

gscottwilson avatar gscottwilson commented on June 21, 2024

Sounds good. Thanks for the heads up

from cvss-v4-calculator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.