redhat-cop / bats-library Goto Github PK

Thoughts.

Add a helper function to:

• https://github.com/redhat-cop/bats-library/blob/master/src/conftest.bash

which filters out (i.e.: rm {file}) which don't match what version is requested

if k8s = 1.20
rm anything that is greater than kubernetes-1.20.rego

• https://github.com/swade1987/deprek8ion/tree/master/policies

if k8s = 4_2
rm anything that is greater than 4_2/
https://github.com/redhat-cop/rego-policies/tree/master/policy/ocp/deprecated

we can currently process a helm template via:

• https://github.com/redhat-cop/bats-library/blob/master/src/helm.bash

would also be helpful to process kustomize as well, i.e.:

git clone https://github.com/redhat-cop/gitops-catalog.git
kustomize build acs-operator/overlays/aggregate

@oybed ; repo was created using MIT license. Most of the other repos using Apache for their license (rego/github-actions/container-pipelines/containers-quickstarts).

Any reason this is different?

@pabrahamsson ; my favourite topic. can we get the bot enabled for this repo?

What are peoples thoughts on how we do GitHub releases for this repo? I am presuming each release would follow a naming of:

• {lib}-{verison}

i.e.: yaml-json-manipulation-1.0.0

but thought I'd see if anyone else has other ideas?

cc @springdo @pabrahamsson

Create instructions for contributing, testing and linting things etc

FYI @garethahealy

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update actions/checkout action to v4.1.7
• Update github/codeql-action action to v3.25.10

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Thoughts.

Thoughts.

@jfilipcz in PR https://github.com/redhat-cop/bats-library/pull/36/files you added linting. but helm lint is called after helm template. if there are any issues with the chart, helm template will fail printing out the reason which seems to negate the need for helm lint.

https://github.com/redhat-cop/bats-library/blob/master/src/helm.bash#L32-L40

if helm lint is needed, shouldn't it go before helm template? or am I missing something.