Expected Behavior
A user will be able to see notifications about own events

Current Behavior
no notifications page.

Expected Behavior

reduce the creation of entities in test files. It would make the code more readable.

Current Behavior

game event fixture in every test file, same game event creation

Acceptance Criteria

one game event fixture in conftest
some adjustments in relevant test files.

Expected Behavior

users will have a template of a login page.

Current Behavior

There is currently no template for it

Acceptance Criteria

1. Login page template should be added
2. Relevant routing for the template should be added
3. Small adjustments in the base.html should be done.
4. Relevant tests for the login mechanism should be added

removing the class BallGame from game_event models, because it is already in Player class.

in PlayerRating i want to modify the user_id field that is foreign key to the Player Table to be just player.

Expected Behavior

On game-event page, should be a chat to the specific event.

Current Behavior

not implemented

A file that makes GitHub automatically request a review on a PR that changes the code in the repo.

As a reviewer in this repo, I have noticed a struggle to write clear and concise pull request descriptions. This can make it difficult for reviewers to understand the purpose and scope of the proposed changes.

To help address this issue, I recommend adding a pull request template.
A template would provide a structured format for writing descriptions, which can improve clarity and consistency.

The template could include sections for:

• Summary of changes: A brief overview of what the pull request accomplishes
• Context: The problem or issue that the changes aim to solve
• Implementation details: Any technical details or considerations that reviewers should be aware of
• Testing plan: Steps taken to ensure the changes have been properly tested and verified

Templates help you better understand what information you should include in your description and help reviewers evaluate your proposed changes.
This improves the overall quality of submissions and makes the review process more efficient and effective.

Please let me know what you think.

Expected Behavior

users will have template that contains form fields to create game events

Current Behavior

no such template exist

Acceptance Criteria

1. create_game_event template must be added
2. routing for template must be added

Expected Behavior

users will be option to click of the button to create a new game event, form already exists.

Current Behavior

There is no option to create a new game event from all games.

Acceptance Criteria

Edit game-events template, add button, add logic when clicking the button.
Relevant tests for the mechanism after clicking the button and after creating a game event.

Expected Behavior

• Game events should not be left empty. When the last player leaves an event, the event should be automatically deleted.
• Automatically add the player who created the event to the event.
• Logging in will be required for the player to create a new event.

Current Behavior

• Game events can currently created without any players being linked to them.

Acceptance Criteria

After creating a game event, the player who created the event will be automatically added to it.

Expected Behavior
A ERD will include Notification entity

Current Behavior
Notification Entity does not exist.

modify the player_id field name to be player and game_event_id name to be game_event

Removed User ID of ball responsible field from Game Event table, added ball responsible field to Game Event Player.

Expected Behavior

Users could see the current weather in the city where the court of the game event is located

Current Behavior

There is currently no implementation for it

Acceptance Criteria

1. Set an API key for a weather api
2. Modify view - add a get request to the weather api to get the weather
3. Change the template for the game events table
4. add tests

Expected Behavior

Add some design for our web app by the logo's colors

Current Behavior

There is no coherent web design

Acceptance Criteria

1. styels.css file must be added ( for coherent colors and web design)
2. game-event.css & game-event.html files must be changed
3. base.html must be changed

Expected Behavior

Because the project uses only static players without the ability to register at the moment, there is a need for a large number of static users of players for regular work.

Current Behavior

There are no players users at all in the data migrations

Steps to Reproduce

• Create static Players users.
• Modify data migrations in Meetbalss app

When adding the pytest framework, we created a couple of dummy test cases. Those should now be removed.

To improve readability, there’s a need to divide this test into three functions:

1. function for creating GameEventPlayers.
2. A function that will test whether a player is in the expected events.
3. A function that will test whether an event has the expected players.

In this way every function will be smaller, easier to read and understand.

Need to add:

1. PyTest
2. pytest.yml file to .github/workflows to automate pytest check.

We can see the navbar in base.html.
In the navbar there is "Games" button. When you press it, you'll be routed to http://127.0.0.1:8000/game-events.
Currently, there is no such path available.
@amitCohen2 and I will be working on this new feature.

flake8 is failing as the existing python files do not conform with flake8.
See this dummy PR for details: https://github.com/redhat-beyond/MeetBalls/pull/11/checks

Expected Behavior

The test test_delete_player_deletes_player_ratings at player_rating/tests.py should pass also when we have a real data in out DB.

Current Behavior

If we have a real users/players in our DB the test fails because it uses hard coded numbers. It didn't take into consideration other users exist other than the fixture.

Steps to Reproduce

• Fix the test

In "test_create_three_courts_without_id":

1. Need to change variable names from court_id1 to court1.
2. Fix the check: Instead of checking IDs 1,2,3, I should check IDs: First, First+1, First+2.

I'll get to it ASAP.

Expected Behavior

Application templates should have a base.html template file so they would extends it.

Current Behavior

There are no templates at all.

Acceptance Criteria

Add a base.html template to the meet_balls_app/templates

Need to do this change on game_event tests.py for preventing warnings:
from django.utils import timezone
TEST_TIME = timezone.now()

Say we have a GameEvent that is supposed to happen in a few days, with 30 players want to participate.
The court size was 30 so everything works well.
But now, for some reason, the court size is getting smaller, for example to 20.
What should happen? Should we not allow decreasing the court size? Should we keep everything the same?

The issue is related to Court PR, and will be discussed in our next meeting.

Expected Behavior

reduce the creation of entities in test files. It would make the code more readable.

Current Behavior

game event player fixture in every test file, same game event player creation

Acceptance Criteria

one game event player fixture in conftest
some adjustments in relevant test files.

Expected Behavior
A user will be able to register to the app.

Current Behavior
no registration page.

modify field court_id to be court

Expected Behavior

reduce the creation of entities in test files. It would make the code more readable.

Current Behavior

court fixture in every test file, same court creation

Acceptance Criteria

one court fixture in conftest
some adjustments in relevant test files.

Need to add:

1. Message model
2. Don't forget to add test for Message model

Expected Behavior

.idea should be in .gitignore

Current Behavior

.gitignore dont have line for .idea

Acceptance Criteria

just need to add .idea line to .gitignore

When creating a game event, the number of players required to participate might be grater then the actual number of player in the event, Therefore, it may be problematic with our logic after creating a new event.
We could make the minimum number of players field optional, rather than mandatory.

Expected Behavior

users will have template that contains a specific game event.

Current Behavior

no such template exist

Acceptance Criteria

game_event template must be added
routing for template must be added

Expected Behavior

Players should have profile page,
Profile page should include games participation history and ratings of player

Current Behavior

not implemented

Time of an event can't be before the time it was created.
In addition, the expected time of a game event most be a least 4 hours or more after for the time it was created.