redhat-beyond / buytogether Goto Github PK

• Show all supplier's deliveries
• option to add/delete delivery
  #95

by the DFD we need to display the products of the supplier and the ability to search for a product.
#91

i have fixed the client module with its migrations tests,it was creating a client with false fields and fixed pytest warning that was about collecting TestFields as a test class.

#17

display name of user in nav bar
#89

by the ERD supplier module is required.
#16

#45
Add client module and make migrations.

#27

In this modification:

• We have deleted the field user_type that was in the table User because:

1. It is not usable
2. not effective
3. extra field that was added by us and cant not be used either now or in the future

i will be adding the login functionality with the signup
and i will do the authenticate part for the supplier in order to continue
doing the project logic.

#55
I add client app again in the right branch.
also made some fixes.

In this i am fixing the product template as said
and all templates should be in the base DIR/template.

add more tests for supplier module.
#51
add register method and register check

i have fixed the supplier module with its migrations tests,it was creating a client with false fields.

delete_product is using broad exception (except Exception). This will make us ignore all failures there, which is seldom what we're after.

The exception needs to change so we ignore only the specific exception that is raised when we try to delete a non-existing element.

• Show order list of the client
• Add a new order

Create a web page that display all the ordered of each client.
This page needs to contains a ordered_products table and options to add order/delete order/change quantity.

I have :
fixed the migration files
fixed the order of the migration files
fixed the customuser
created the currect way of using the User from django
removed few functions that is not needed
removed few tests that is not needed because django User have created a tests for them already
changed few tests
fixed the migration tests
wrote a better way of testing and the order of saving that happend because of they change of the customuser
and few more.

We have been added the erd for our app #22

explain about vagrant up, virtual box etc.

#44

if the logged user is supplier, he will be directed to suppliers page.
#80

log in tag was missing and i have added it in order to have login signup tags on the main page for not logged in users.

#28

In this PR I update our description page with links to our linkedIn accounts.
#106

The product's index function is using a query which needs to be clarified.

need to remove user type field from User
fix #22

Need to add supplier web page.
#63

Move all the fixtures to conftest so all the fixtures will be in the conftest file and don't be in test file.

in this model the following has been done :
**** creating an app with the name supplierProduct .

1. creating model which has two foreign keys : one foreign key from product , one from supplier
   • note : the supplier has not been merged yet and since this model depends on it , this code is not final and any changes
     on the supplier model will effect this model
2. creating test functions : test.py
3. adding 0002_test_data.py file

https://github.com/redhat-beyond/beyond08-group3/blob/890f615b8e124afa814800a1b04b989d2173fd43/setup.sh#L15
the address mentioned above, doesn't open any webpage.
please correct it with the following:
http://127.0.0.1:8000/

In this module i have added :

• functions that is related to the module
• module fields with checks and validators
• 0002_test_data to test the module
• register it to the admin
• added it to the project
• added tests to test the functionallity of the module

UI and user input and query to the client and suppliers will be done in a seperated PR and Issue.

• #53

i have added logging out functionality so if you are logged in you can log out but if you are logged out you will not be able to log out.

The contributing guide needs to define the process for reviewing a PR and the quality of the commits.

Some suggestions:

• Descriptive commit message titles and bodies, explaining what the PR is about and if it depends on any other unmerged PRs
• Students-driven quality review cycles (no LGTMs) and only then mentors provide their reviews.
• Code review needs to be according to the task requirements - i.e. you need to know the acceptance criteria of the task before reviewing.
• Code needs to be merged before the weekend.

I (@yftacherzog) asked for TEST_DATA to be reused between the tests and the migration files, and @thetaxas2468 did that, defining the TEST_DATA inside the tests, which @Omeramsc later said should not be done.

I still wouldn't like it to be defined twice, as it makes the tests more fragile given the coupling between the migration data and the tests content. I also agree that it should be defined in the migration file.

If no objections, I think the proper way to have it is to define it on the migration files, and then import it on the tests. Generally speaking, we prefer having the tests import constants coming from the code being tested rather than the other way around.

• Create OrderedProduct module - fields and features.
• Write a test data.
• Write a pytest tests.

Done on PR #58

need to add the button mentioned above.
#101

I have edited the setup.sh and added more 2 lines that do migrate the migrations that already there

In this issue that is related to

• #65

• paths and views has been modified

• main web page has been updated

• description page has been added

i have changed many things in order to
get a correct project and to have the authentication ability
and future functions that is built in django user model
here are few things:

• I have added a one to one field for each user and supplier
  that is pointed to a user account in django user model
• I have changed the migration tests in order to get
  a correct test that do not fail
• Updated some of few functions in client and supplier
• Update confest file in order to get rid off warnings
• Updated pytest test files to have a correct tests

added idea folder to gitignore
#49

Need to add Log in feature
solves #79

#13
edit: fix #48
need to clarify whether linking an issue is required.

Review Requirements

• When reviewing, confirm that the code accomplishes the requirements and the acceptance criteria by using one or both ways:
  A GitHub issue: the code fixes the problem.
  Adding a feature: elaborate in the commit the purpose of the code.
  Both cases should have accompanying unit tests that cover all the relevant edge cases.

Functions are to get all the products from the data base,and we have tested it using pytest with test called get_all_products.