redcmd / tmlanguage-syntax-highlighter Goto Github PK

Formatting adds these three wihitespaces that I personally don't like:

"3": { "name": "punctuation.definition.markdown" },
      ^                                         ^ ws
"fileTypes": [ ],
              ^ ws

Maybe add a configuration option "whitespaceInsideBrackts": {"type": "boolean"}? I can make a PR, if you like.

Currently, this extension will silently accept items without comma

while the builtinjson mode will show a prominent error

How about implementing this by using a simple sementic highlight or some textmate rules like:

{
    "match": "\\}\\s*\\{",
    "name": "invalid.illegal.xxx"
}

Or perhaps you'd like to wait for the official VS Code Team to support using custom textmate rules together with the builtin mode together (As I've seen in your other issues)

The formatter is using tabs for indentation, but it should use selected indentation instead.

I've just add a new feature. CallStack (name change?)

just install the latest pre-release version

open any basic document and right click => Show TextMate Calling Stack
It'll open up a new view showing you the tree structure of how TextMate tokenized the file

each element is a begin or match rule
with the label being name

most things are wip
while, end and captures don't show up correctly

I am yet to implement the Follow Cursor feature
but the goto feature is mostly working so far
just click the little right arrow on an element and it'll take you to the corresponding rule

what icon should I have for each element?
prob something different for begin/match/end/while/captures etc

for the label
should I use name, contentname, comment, or the captured text?
being in mind that any of them could be blank
more so in different grammars

annoyingly I had to modify the original vscode-textmate code to be able to extract the textmate tree structure
I was thinking of using https://github.com/ds300/patch-package instead of including the entire vscode-textmate repo
does the patch package tool work well on 50k+ character single line files?

currently
many bugs

As shown in the picture, the default style is markup.italic, however, it makes distinguish | and / hard (especially if they're not adjacent)

How about change the style to bold or simply remove the italic?

Todo:
Investigate microsoft/vscode#170497
disable bracket pair colouring by default on all non-nesting brackets

It doesn't show errors if there is a missing bracket:

{
{"test": "blah"
}

Parens and single quotes are listed in regex.language-configuration.json as surround pairs, but they're not surrounding in a tmLanguage.json file.

I was gonna open a PR adding just parens to the tmLanguage.json configuration but it looks like there's a bigger issue with the embedded language's configuration not applying.

It seems changes in package.json are not reflected in tmLanguage.json
And some scopes don't have any colors:

I think it was one time after VSCode restart that is showed all the missing colors for a split of a second, then removed them.

[EDIT]
might be conflicting with other extension? will check

It's place is in 'Releases'.