Giter Club home page Giter Club logo

red5pro-simple-auth-plugin's Issues

Incomplete Documentation

PassthroughAuthenticator is (almost) documented and Iknow can be used by simply adding:
simpleauth.subscribe.authenticator=org.red5.server.plugin.simpleauth.impl.PassthroughAuthenticator

to the properties file. The rest? Completely undocumented as far as I can tell, eg HTTPAuthenticator.java sounds like it might do something useful, but there is zero documentation on how to use it ...

suggest either documenting them or removing them from the repo.

RoundTripAuthenticationValidator docs show type is passed invalidate callback

The docs for the RoundTripAuthenticationValidator state that the "type" is passed in the invalidate endpoint call:
https://github.com/red5pro/red5pro-simple-auth-plugin/blob/master/red5proroundtripauthvalidator.md#invalidate-credentials

However, the type parameter is not passed in the call. I looked at the code and the invalidate callback appears to only apply to publisher connections, not subscriber connections.

if (conn.hasAttribute("roletype") && conn.getStringAttribute("roletype").equals("publisher")

Not sure if just the docs need to be corrected, or if the functionality in the invalidate is missing the type parameter in the invalidate callback.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.