Giter Club home page Giter Club logo

api-plugin-taxes-flat-rate's Introduction

This repository is deprecated

This code is now located in our monorepo here

api-plugin-taxes-flat-rate

npm (scoped) CircleCI semantic-release

Summary

Flat Rate Taxes plugin for the Reaction API

Developer Certificate of Origin

We use the Developer Certificate of Origin (DCO) in lieu of a Contributor License Agreement for all contributions to Reaction Commerce open source projects. We request that contributors agree to the terms of the DCO and indicate that agreement by signing all commits made to Reaction Commerce projects by adding a line with your name and email address to every Git commit message contributed:

Signed-off-by: Jane Doe <[email protected]>

You can sign your commit automatically with Git by using git commit -s if you have your user.name and user.email set as part of your Git configuration.

We ask that you use your real name (please no anonymous contributions or pseudonyms). By signing your commit you are certifying that you have the right have the right to submit it under the open source license used by that particular Reaction Commerce project. You must use your real name (no pseudonyms or anonymous contributions are allowed.)

We use the Probot DCO GitHub app to check for DCO signoffs of every commit.

If you forget to sign your commits, the DCO bot will remind you and give you detailed instructions for how to amend your commits to add a signature.

License

This Reaction plugin is GNU GPLv3 Licensed

api-plugin-taxes-flat-rate's People

Contributors

akarshit avatar aldeed avatar brent-hoover avatar delagroove avatar dependabot[bot] avatar focusaurus avatar kieckhafer avatar loan-laux avatar mikemurray avatar mpaktiti avatar snyk-bot avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

api-plugin-taxes-flat-rate's Issues

Tax rates for "any jurisdiction" don't get applied

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?
  • Did you search the issue queue for existing issue? Search issues

Issue Description

Tax rates created for no specific jurisdiction should be applied to all billing addresses. Currently, they don't get applied at all.

Steps to Reproduce

  1. Create a tax rate for no specific jurisdiction
  2. Create a product and assign it this tax rate
  3. Add this product to a cart, go to checkout
  4. Notice that the tax shown is $0

Possible Solution

Something must be checking for a jurisdiction name in calculateOrderTaxes and ignoring codes that don't apply to any specific jurisdiction. We need to make sure the case for global tax rates is wired-in too.

Tax rates are applied as percentage and not decimal

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?
  • Did you search the issue queue for existing issue? Search issues
    -->

Issue Description

In reaction-admin, when you add a tax rate, the form tells you to enter the rate as a decimal. For example, 0.05 equals to a 5% tax.

However, when you create a tax rate following this rule and shop for products using this tax rate on the storefront, the tax calculation isn't actually price * taxRate (which it should be), but rather price * taxRate / 100 (which would only be correct if our tax rate was a percentage to start with, i.e. 5 and not 0.05).

Steps to Reproduce

  1. Create a tax rate following the instructions in the tax rate form
  2. Create a product and assign it this tax rate
  3. Add the product to a cart, go to checkout
  4. Notice that the tax shown in the price breakdown is 100 times less what it should be

Possible Solution

We need to decide whether we want the tax rates to be entered by admins as percentages or decimals. Then, either fix the form in reaction-admin, or fix this plugin to handle the calculation the right way.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.