rdtho2525 / refactor-tractor Goto Github PK

• item

right now, the last test in Hydration says should find sleep quality by day for that days week

looks like it's actually testing a hydration thing and might just need to be renamed

we can't see why this is needed

(from original project spec)

• then show us how it works
• and make our code prettier!

it's not helpful, not called for in the spec, and taking up a lot of space -- but also it's not really hurting thing and as David said, "if it ain't broke don't fix it"

GET - http://localhost:3001/api/v1/users

idea: maybe fix by adding check so that if parameters are undefined, have a message saying no real data was passed through

Also not immediately clear why we even need this; maybe we could just eliminate that method? It seems to be related to calculateRandomWeekOunces and the display on DOM of some way-past week's water consumption. Just remove all this stuff?

• remove all-user average sleep quality

• remove data from random week in July of 2019 (second pink box on the right)

• display user sleep quality over latest week (sleep hours is already there but need to add quality)

• display this particular user's all-time average for sleep hours and quality (third bullet in spec)

There are two unused parameters: dataSet and date. Should they be used? Or should they be deleted?

from original spec, iteration 1 dashboard, third bullet

• have functionality related to this on line 91 of scripts.js but missing the actual function that would do it.
• note that this should not be hard-coded! Need to actually calculate the average

GET - http://localhost:3001/api/v1/activity

Second-to-last bullet in Iteration 3 Sleep data asks to find all users with avg sleep quality greater than 3, but in Sleep-test.js the fourth-to-last and third-to-last tests are looking for the user with the best quality sleep

... instead of having it buried in the "Friend Activity" describe block, where it doesn't belong

• As part of this, make sure to fix description of hydration test that makes it sound like only the first week's data is included
• Do things like "calculate" -> "calc"

Consider making User-Repo the parent class

(just scrolling through Sleep.js, for example, we noticed a few places where there were nearly identical functions that differ only in whether they're dealing with sleep hours or sleep quality)

GET - http://localhost:3001/api/v1/sleep

Refactor the existing CSS into Sass:

• Break your Sass out into separate files

  • index.scss
  • variables.scss
  • additional partials (if needed)

• Install normalize or reset file to help with cross-browser compatibility

• Review for other opportunities for modularity/partials

• Draft charts
• Insert data from server

https://www.chartjs.org/

David sez: "I think chart.js works well! It’s definitely the quickest option. If you really wanted a challenge, you could also consider D3."

Lucas from Mod 3 sez:

• there are YouTube videos available
• we can consult his GH repo if needed and/or ask him questions
• best way forward is to get it implemented and then build one chart to play around with
• can set up in two ways:
  • (more difficult option) as a dependency
  • (easier but not as clean option) import via a scripts tag in html; charts will need to live in our main js file and in onload functions
  • if the easy way goes smoothly enough, we can always implement the dependency way later to make things cleaner

POST - http://localhost:3001/api/v1/activity

{
"userID": integer, "
date": string,
"numSteps": integer,
"minutesActive": integer,
"flightsOfStairs": integer
}

• Error Handling

POST - http://localhost:3001/api/v1/hydration

{
"userID": integer,
"date": string,
"numOunces": integer
}

• Error Handling

POST - http://localhost:3001/api/v1/sleep

{
"userID": integer,
"date": string,
"hoursSlept": integer,
"sleepQuality": integer
}

• Error Handling

bug is that userRepo.getWeekFromDate (and probably also userRepo.getFirstWeek) gets the seven date entries leading up to the current one, which may or may not be the previous week.

For example, in the Hydration class file, something like userRepo.getWeekFromDate('2019/09/18', 4, this.hydrationData will return an array like

[
  { userID: 4, date: '2019/09/18', numOunces: 40 },
  { userID: 4, date: '2019/09/17', numOunces: 40 },
  { userID: 4, date: '2019/09/16', numOunces: 30 },
  { userID: 4, date: '2019/09/15', numOunces: 30 },
  { userID: 4, date: '2019/04/15', numOunces: 36 },
  { userID: 4, date: '2019/03/15', numOunces: 35 },
  { userID: 4, date: '2018/02/01', numOunces: 28 }
]

where the last three dates are from months ago, not earlier dates in the same week.

Note that I ran into this issue using the sample data in hydration-test.js, so the problematic array above will be different when the methods are run using the real data.

Those methods will also return an array with less than seven entries if there aren't seven days leading up to the relevant date.

GET - http://localhost:3001/api/v1/hydration

right now, it looks like it only checks that steps are equal to goal and will return false if steps exceed goal, but of course the goal is met even if the steps are greater than that goal