Giter Club home page Giter Club logo

rdoeffinger / dictionary Goto Github PK

View Code? Open in Web Editor NEW
306.0 306.0 67.0 99.77 MB

"QuickDic" offline Dictionary App for Android. Provided downloadable dictionaries are based on Wiktionaries but can also be created from other sources (see DictionaryPC). Remember to use --recursive when cloning! Fork of project that used to be hosted at code.google.com/p/quickdic-dictionary.

License: Apache License 2.0

Shell 0.84% HTML 2.27% Java 96.89%
android-app dictionary

dictionary's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

dictionary's Issues

Fix back button behaviour

When pressing the back button from a word or dictionary all kinds of strange things happen.
Also the HTML pages have a back arrow even on Android 2.3, but there it doesn't have any effect at all.
This needs to be reviewed and change to have at least somewhat sensible behaviour.

Selecting and copying

I'd like to copy a single or a group of words from a translation. Problems are:

  • Only single words can be selected
  • I can search for the selected word, but when I hit "copy" the whole entry (both languages) is copied. (Workaround: search, then copy from search field). This is not the case for the "main word" of an entry (under which several entries are grouped). It can be selected and copied as is.
  • When I select a word from another entry the 1st remains highlighted, which is certainly not intended or expected.

Accordingly I propose to:

  • enable the common text selection in Android (where I have the draggable start and end marker) as in the "detail view" of "blue link entries".
  • add a context menu item "copy selection", rename "copy" -> "copy entry"
  • fire the deleteSelection method upon selection or whatever is necessary (just guessing wildly here)

Better selection of storage location

Currently it is just a text field to enter a path.
It should instead also have a more user-friendly selection like "internal storage", "external SD" etc.

RO is not Romanche in french but Romanian, but why do we translate this?

Hi,

this looks wrong: https://github.com/rdoeffinger/Dictionary/blob/master/res/values-fr/languages.xml#L66
RO is Romanian in english, Roumain in french.

But I do not really understand why we have to translate such lists, as the content is already included in standards.

From this link: http://stackoverflow.com/questions/7973023/what-is-the-list-of-supported-languages-locales-on-android
I went to this page: https://developer.android.com/reference/java/util/Locale.html
I understand "getDisplayName" will give you the correct translated version of the language:
new Locale("en").getDisplayName(Locale.FRANCE) -> anglais

Thanks a lot for your help and this software, I like it very much!

Do not use flag for language

it would be great to only use names and not flags to identify languages.
If any interest, here is a full article about this subject: https://www.cs.tut.fi/~jkorpela/flags.html

But we may only keep this short quotation:

The CEN Workshop Agreement European Culturally Specific ICT Requirements says:

The use of national flags to denote language, although convenient to implement, is another potential source of major irritation to the users, particularly for native speakers of the language outside the thus indicated country.
Source (in PDF format): CWA 14094, clause 5.9

thanks for your help and this great software!

Exporting entry to AnkiDroid via share - wrong field assignment

When I export an entry (e.g. "to set up") to AnkiDroid via "Share it" appears there in two fields, e.g. "Front" and "Back".

This is good as apparently Quickdic transmits and AnkiDroid recognizes two separate fields (e.g. "Front" & "Back"). [It's not just the first word that is separated from the rest as a test with a two words entry (e.g. "Costa Rica") shows. However those entries are always blue link entries and no content is shared.]

However the fields' content is not quite correct as "Front" contains only the "main word" ("set") while "Back" contains both sides/languages of the actual entry.

Hence I need to do some tedious copying and pasting in AnkiDroid which would be unnecessary if the shared data were assigned correctly.

According to my observations this issue cannot be fixed in AnkiDroid.

I propose to populate the shared data with: "entry left language SEPARATOR entry right language".

Better reporting of download/unpack issues

Currently issues during download or unpacking result in only very quickly disappearing pop-ups.
This makes them easy to miss and harder to debug and fix download issues reported by users.

IT - RU

Hi! Is possible add Italian - Russian dictionary??

Put app in F-Droid.

The old QuickDic was in F-Droid... it would be nice to put this new app in F-Droid too!

Duplicate dictionaries with different word counts

I noticed there are a few dictionaries that are the same [language]-[language] but have different word counts. For example, there are two English-German and English-Greek. I'm not sure if this is something we have any control over but wouldn't it make sense to merge those two duplicate dictionaries into one?

Or is this just how the dictionaries are provided?

Thank you for reviving QuickDic btw, I was pretty bummed when I reinstalled it only to find out it didn't work.

screenshot_2015-11-25-19-21-57

Publishing Dictionaries

Is there a place to publish dictionaries to?

QuickDic looks like a reasonable app for dropping dictionaries into that we generated from linguistic fieldwork (Alorese Abui – Indonesian right now, possibly to be extended to other eastern Indonesian languages on one side and English on the other side).

It works well so far, but it would be nice to make our dicts available easily through QuickDic's crawler and download function. Do you have (plans for) a repository where one could submit pull requests with links to locations of .quickdic files to, so the app will be aware of them as downloadable dictionaries?

Unable to download dictionaries

I just installed the application, then clicked on the download icon for the English dictionary. The download manager starts but does not seem to be doing anything. After a few seconds the application reports the error "Download failed: null".

Updates files

Add a "control updates" button + manual download, or a "automatic updates" button + automatic download

Feature Request: Combined lookup in both languages

To save the hassle of selecting the correct language the app could offer the option to look up in both languages simultaneously.

I realize that this might be a little difficult to implement as the lookup does not work as a filter (where it would be easy to add), but jumps to the first find in the long list.

Hence, I propose to let it automatically switch the language in case the search term is not found in the active language but in the other one instead.

Feature Request: Combine dictionaries

I have created dictionaries from dict.cc data for English, Russian, French and Spanish as they offer some words and some grammatical information which cannot be found in the standard dictionaries.

Also, they don't have the annoying "linked entries" where you have to click on a blue link and scroll a while to find the translation.

Looking up a rare word can take a while, because I have to switch between dictionaries, without knowing which one is active, before I try Leo, Google Translate or whatever.

I propose to implement an option for merging dictionaries / combined lookup. That could be automatic for all dictionaries of the same language and would thus require only one additional checkbox.

Crash when trying to download dictionaries

Hello. When attempting to download dictionaries, quickdic is crashing with "Unfortunately, quickdic has stopped". This occurs when pressing the download button on any of the downloadable dictionaries. I've used alogcat to retrieve some (hopefully useful) debugging output.

OS: Cyanogenmod 11 M12 (4.4.4 kitkat)

Here's the exception from the process (retrieved from alogcat):

alogcat.2016-01-28-00-01-09-0500.txt:D/AndroidRuntime( 3083): Shutting down VM alogcat.2016-01-28-00-01-09-0500.txt:W/dalvikvm( 3083): threadid=1: thread exiting with uncaught exception (group=0x41abbce0) alogcat.2016-01-28-00-01-09-0500.txt:E/ActivityThread( 3083): Failed to find provider info for downloads alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): FATAL EXCEPTION: main alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): Process: de.reimardoeffinger.quickdic, PID: 3083 alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): java.lang.NullPointerException alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at com.hughes.android.dictionary.DictionaryManagerActivity.a(Unknown Source) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at com.hughes.android.dictionary.DictionaryManagerActivity.a(Unknown Source) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at com.hughes.android.dictionary.ba.onClick(Unknown Source) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at android.view.View.performClick(View.java:4445) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at android.view.View$PerformClick.run(View.java:18446) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at android.os.Handler.handleCallback(Handler.java:733) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at android.os.Handler.dispatchMessage(Handler.java:95) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at android.os.Looper.loop(Looper.java:136) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at android.app.ActivityThread.main(ActivityThread.java:5146) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at java.lang.reflect.Method.invokeNative(Native Method) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at java.lang.reflect.Method.invoke(Method.java:515) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:732) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:566) alogcat.2016-01-28-00-01-09-0500.txt:E/AndroidRuntime( 3083): at dalvik.system.NativeStart.main(Native Method) alogcat.2016-01-28-00-01-09-0500.txt:I/Process ( 3083): Sending signal. PID: 3083 SIG: 9 alogcat.2016-01-28-00-01-09-0500.txt:I/ActivityManager( 583): Process de.reimardoeffinger.quickdic (pid 3083) has died.

Here is the entire alogcat session:
alogcat.2016-01-28-00-01-09-0500.txt

Current Dictionary not identified

I use two dictionaries for the same language because some words can only be found in one, others in the other. So I often switch between the two, without knowing which one is currently active.

  • The active dictionary is only identified via the flag, which is obviously the same for both dictionaries. (Not counting the info via "About dictionary...")
  • In the dictionary list the active dictionary is not highlighted.
  • Selecting the active dictionary from the list is not quicker than switching to any other. If it was I'd know that I haven't switched.

I propose to implement any of these (in descending preference):

  • fix #31
  • highlight/deactivate/grey out the active dictionary in the dictionary list
  • skip the switching process if the active dictionary is selected
  • add an info about the current dictionary in the dictionary view

Fileformat

Is there a file format definition I can use to create a dictionary file for additional languages I am considering.
Thank you for your work.

Issues with Russian dictionary

Using the DE-RU dictionary from 15/DEC/2015 with Quickdict 5.2.6 I noticed the following issues:

  • there are polish words, e.g. some declinations of "Quedlinburg" and above a couple beginning with "pł"
  • some words cannot be found via look-up although they are present, try "разме́р", then look up "Größe". Same with мудрость-Weisheit.
  • I also saw the German word "Mythologie" on the Russian side, but I can't find it again

Blue link entries

I don't see the logic or necessity for what I call, in lack of a better term, "blue link" entries. With that I mean that some entries' translations are not shown in the list. Instead the are blue and underlined and after tapping it's detailed content is shown. It's nice to have the details but the disadvantage is:

  • the translation is not visible at once
  • the actual translation (usually the info I am looking for) is hidden in the lower part and only visible after some scrolling
  • the entry cannot be exported via "share" from the list (exports only the search term). Exporting via select and share in the detail view only exports as one field to AnkiDroid (see #37 )
  • the detailed info is not indexed, hence the translation cannot be looked up (e.g. Spanish "muerte" = German "Sterben". "Sterben" is not found (, only the verb "sterben"=morir).

I am aware that the generation of the dictionary obviously is an automated process and the source data seems to be quite messy given the inconsistent structure of the created dictionary. Still, there must be some attribute of an entry that triggers the creation of such a "blue link entry" and I propose to ignore/suppress that.

Fix software keyboard popup after pressing up/down buttons

Software keyboard alternately pops up and disappears while navigating through the dictionary using up/down buttons.

These buttons are useful when scrolling the list and reading words from new language to learn them, because it's much easier to press one button then to swipe the screen all the time. But popping up keyboard screws the whole learning process. It seems like pretty straightforward issue to fix, but i want to report it here before diving into project's source code.

Lookup sporadically not working

In the Japanese-German dictionary I often, not always, experience the following:

  • After pasting a kanji (from AnkiDroid) in the search box nothing happens.
  • Workaround: switching to German and back, or typing something before the pasted kanji.

Sorry, it's not easily reproducible as it only happens sometimes. Not right now, of course...

EDIT: Also happens in other dictionaries. I just switched to a dictionary after having entered a word. That word was only looked up after typing something.

This is reproducible with a search term of two words ("give up") in both English dictionaries (not in FR or ES, though).

Sort by name

Once downloaded dictionaries (also in no particular order), add a "reorder by name" button to facilitate the consultation

Bug: multiple downloads

Why is it possible to download 7 times at once the same dictionary ??
When you press the download button of a dictionary currently downloading it add the download with 'the-name-5' for example.

Go to random word

Hi

It would be very nice if there was an interface item that opens a random wprd frpm the current language.

Thanks

almost no space for searching by default

These buttons use a lot of space and are not practically used so this option should be disabled by default.

Also moving the flag to the left and using the same space for the flag and the magnifying glass for changing the language.

I.e. pressing the magnifying glass or the flag change the language.

dutch and german to english dictionaries work fine (the title shouldn't be "EN-DE" though)

the dutch to english (EN-NL) and german to english (EN-DE) dictionaries work fine on my phone.

the orders of the entries might be better but that is probably an issue for wiktionary??

one thing though is the title in the dictionary manager for the german to english is "EN-DE", not the names of the languages like the other ones, for example "English-Japanese" or "English-Dutch". It should be changed.

thank you so much!!! i was hoping someone would save quickdic!!!! :-)

Feature Request: Option to put the bar at the bottom

I use a lot this app (thanks so much) and I use it with 3 languages: Spanish, English and Portuguese so I'm constantly changing the language. I think it would be very much comfortable if we had the flag icon nearer to the finger. A solution for this could be having the bar at the bottom of the screen or between the search bar and the menu button (or both).

Improvement: replace {{...}}

Let's replace the {{...}} to make a better dictionary, and easier reading

For example:

  • {{T|en}} becomes a little English flag ({{T|...}} mean traduction in ...)
  • {{trad+|en|coach}} becomes 'coach' and maybe it is possible to add a link to this word in an English dictionary
  • {{S|...}} is a new section, some formatting could ease reading
  • And there are a lot of other to properly format

Ressources:

Show / Hide are shown wrongly

When we want to download any dictionary, all the available dictionaries are shown and there's a button to Show and Hide them but seems like they appear when they don't have to:

If the dictionaries are shown there's a Show button instead of Hide and vice versa.

updated dictionaries placed in wrong place and not extracted

i was using 5.1.3 at the time (just updated now to 5.1.4) when i clicked on the icons next to dictionaries that needed updating... it downloaded all of them but placed them in the /storage/emulated/0/ directory on my internal storage instead of in the quickDic directory right there (which was set at the target in the settings). it also failed to extract them. i did this all myself manually and it is working fine.

i am wondering if the updating feature is not working correctly....

sorry i cant test this with 5.1.4 because all my dictionaries are now updated and i deleted the old ones already.

Round materialish buttons are useless and hide important text underneath

First of all thanks @rdoeffinger for keeping this project alive!

I find that the round materialish buttons you recently introduced in the app are useless and actually hinder usability instead of improving it.

Useless because all their actions were already 0 or 1 clicks away in the old interface:

  • Searching is the default action when you enter a dictionary. The cursor is automatically in the search box and keyboard is opened. Thus we need zero clicks to get to it. Even if we clicked somewhere else, searching again required only 1 click in the search box, which is a big target that you can easily hit with your fingers.
  • Clearing the current search word took 1 click in the X button to the right of the search box. Again this is a big target that no one misses.
  • Switching languages also took a single click in the flag, again a big target. This one was somewhat hidden. It is hard for a new user to guess that clicking the flag changes languages. The straightforward solution would be to place (watermark) the two arrows symbol on top of the flag.

Summing up: these new buttons solve no usability issue.

Now, even worse, is the fact that they actually are a usability hindrance, because they hide important text underneath. Checkout what happens in my device:

quickdic-material-buttons

90% of the time we use Quickdic with the keyboard opened. These new buttons take a lot of the precious little space we have left. With them, I am forced to hit the back button to hide the keyboard in order the read the translations. That's something I didn't had to do before. Thus they actually increased the number of clicks for me.

Taking this into consideration, I would urge you to remove these buttons, or at least add a preference's option to do so.

Tips for future UI improvements

The original UI by Thad Hughes is actually really good. All major actions are easy to do with it. I would exercise caution before adding modifications.

I see that you are in the mood to update it to a full blown Material UI. If so, please consider starting such work in a new branch. Besides avoiding breaking the UI on the production app, a new branch would allow you to start from scratch. It is rarely a good move to work iteratively on top of an old UI design. Better start anew and see whether applying Material solutions to this problem renders a better UI than the original Holo theme.

Problem with search in French dictionary

Ni!

Thank you so much for maintaining and further developing this app.

I'm using it with the French Dictionary and I have the following problem in every version since I started using it early this year:

Steps to reproduce:

  1. Open QuickDic and choose the French dictionary
  2. Search for any word in the range from "réethniciserait" to "repointilla"
  3. QuickDic scrolls down to the word "repointilla"

Expected:

QuickDic scrolling down to the searched word.

Hope this ain't so hard to fix. Let me know if you can't reproduce or need more input.

Cheers, ale

How can I create dictionaries with version 6?

I downloaded Dictionary, DictionaryPC and Utils (on 9th january 2016) and was able to create the dictionaries, but only version 7.
I tried to change CURRENT_DICT_VERSION=6 in Dictionary.java and
VERSION=v006 in generate_dictionaries.sh, but still the files seem to have size and structure of version 7, and my ebook-reader device does not recognize them (it needs version 6 only).

How can I generate version 6 files?

Keyboard display issues

On my device I often find the keyboard behaviour irritating:

  • While typing I realize that I am in the wrong language. I switch and the keyboard disappears although I am not done typing. (reproducible)
  • On the other hand sometimes the keyboard unnecessarily pops up over dictionary list hiding the dictionaries in the lower part (not reproducible)

F-Droid version

Hi! Is possible load the last version of your app on F-Droid repo (is stop to 5.3.0)??

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.