rbury / topdeskpsclient Goto Github PK

Is your feature request related to a problem? Please describe.
Improve Get-IncidentList for compatibility and usability

Describe the solution you'd like
All returns should be a pscutomobject to comply with signature.

Describe alternatives you've considered
N/A

Additional context
On error a string is returned instead of a pscustomobject, this would not be expected as it is a return value.

Is your feature request related to a problem? Please describe.
Enum handling of sorting parameter works on string values and contains a large number of permutations (1023)

Describe the solution you'd like
Separate ascending and descending sorting parameters into 2 Enums.
This could be handled using Enums with only 31 permutations per parameter.

Describe alternatives you've considered
Continue parsing parameter as is with string manipulation.

Additional context

Is your feature request related to a problem? Please describe.
When calling connect, the attempt is made to connect and authenticate based on a valid formatted URL

Describe the solution you'd like
With a valid formatted URL, use Test-NetConnection to validate connectivity before connection/authentication attempt.

if(Test-NetConnection -ComputerName $url -InformationLevel Quiet) { ...

Describe alternatives you've considered
Allow connection attempts without testing.

Additional context
Reporting on the connection failure should be using Write-Warning instead of Write-Verbose.