The intro-ocaml from rbonichon

intro-ocaml's People

Watchers

intro-ocaml's Issues

Some Comments/Suggestions (file intro_ocaml.org)

Interesting intro 😃

Typos:
L149: maximun --> maximum
L572: syntactilly --> syntactically
Code typos:

L315: let rec loop vars = --> let rec loop vars = function
L325: let rec loop vars = --> let rec loop vars = function

L825: "is_top"  is not defined?  
  
L866: let rec length match l with --> let rec length l = match l with  

L1043: fun v2 -> v1 + v2 --> fun v2 ->  Some (v1 + v2) ... Maybe?  

L1093: (Eq, Int 3, Int) --> (Eq, Int 3, Int 4) ... Maybe?

Something seems wrong with the last OCaml example. I have:

...

let al =
  List.map (( + ) max_int) [1;2;3;4;5;6;7;]
  |> addition_list ;;
(*
val al : t =
  Add (Int (-4611686018427387904),
   Add (Int (-4611686018427387903),
    Add (Int (-4611686018427387902),
     Add (Int (-4611686018427387901),
      Add (Int (-4611686018427387900),
       Add (Int (-4611686018427387899), Int (-4611686018427387898)))))))
*)

Format.printf "%a@." pp_expr al ;;
(*
-4611686018427387904 +
-4611686018427387903 +
-4611686018427387902 +
-4611686018427387901 +
-4611686018427387900 + -4611686018427387899 + -4611686018427387898
- : unit = ()
*)

Tests with OCaml 4.09.0.

Proposition:
For each OCaml snippet, printing the results given by the REPL is useful, I think.
Example:

let h = Hashtbl.create 7 ;;
(* val h : ('_weak1, '_weak2) Hashtbl.t = <abstr> *)

Hashtbl.add h 1 2 ;;
(* - : unit = () *)

Hashtbl.add h 1 3 ;;
(* - : unit = () *)

Hashtbl.iter (fun k v -> Format.printf "%d -> %d@." k v) h ;;
(*
1 -> 3
1 -> 2
- : unit = ()
*)