Comments (10)
I just pushed a new version to the GitHub repository. Could you please give it a try before I release a new version of the gem?
from casino.
Give me one or two hours, I will test it.
from casino.
I have tested it in my production environment with different browsers on different plattforms and cannot find any issue. Looks good. Since cookies are not easy to debug you may wait with releasing a new gem for one or two days? It is now running in production and I will get quick feedback from our users if there is any overseen issue with custom root urls.
Thank you for the really fast update.
from casino.
Thank you! Let me know how it works out. 😄
from casino.
encodeURIComponent in session.js seems to encode to much. We use OTRS which makes heavy usage of ';' in urls like /otrs/index.pl?Action=AgentTicketZoom;TicketID=65813. OTRS cannot handle this with correct encoding like /otrs/index.pl?Action=AgentTicketZoom%3BTicketID%3D65813 (does not work).
Can we avoid escaping reserved characters like '& = ; ? ' ?
The other stuff works fine.
from casino.
I think the problem is not session.js but the (may be incorrect?) handling of semicolon by casino. A call like
GET "/zas/serviceValidate?service=https%3a%2f%2fmintra3.marienhaus.de%2fotrs%2findex.pl%3fAction%3dAgentTicketZoom%253BTicketID%253D65065&ticket=..."
gives the following parameters (from production.log):
Parameters: {"service"=>"https://mintra3.marienhaus.de/otrs/index.pl?Action=AgentTicketZoom%3BTicketID%3D65065", ...}
The semicolon (%3B) is not decoded, and not the second '=' (%3D).
from casino.
Yeah, it is an old issue with addressable/uri which does not support semicolon as url query separator: sporkmonger/addressable#114
from casino.
We "fixed" this in the OTRS VirtualHost with the following RewriteRules
:
RewriteCond %{QUERY_STRING} Action=AgentTicketZoom%3BTicketID%3D(\d+)
RewriteRule ^/otrs/index.pl /otrs/index.pl?Action=AgentTicketZoom&TicketID=%1 [R]
from casino.
@luxflux : works as a temporary solution, but not for all other URLs like
https://mintra3.marienhaus.de/otrs/index.pl?Action=AgentTicketPhone%3BSubaction%3DStoreNew%3BExpandCustomerName%3D2%3BCustomerUser%3username%40example.com
It is frustrating: addressable/uri ignores semicolon and @, OTRS cannot handle correct encoded urls...
from casino.
Since this is now an encoding/decoding issue, we should create a new ticket for this issue. The original patch (hardcoded /login) in session.js works fine.
from casino.
Related Issues (20)
- Rails 5 support! HOT 6
- How CAS server identify differency domain name HOT 4
- LDAP and ActiveRecord have different extra_attributes
- Login with ember.js app and JWT API HOT 1
- Password Recovery option? HOT 1
- Net timeout error when trying to sign in. HOT 1
- Cannot login to CASino: Gives me 403 Forbidden HOT 26
- hi bro..
- CASino ActiveRecord Authentication HOT 2
- Trying to install CASino App. Experiencing bundle exec rake db:migrate issues.
- Resurrecting SAML2 Integration with CASino #94
- User connexion problem
- Mongo for storing schema
- interest in maintainer help? HOT 16
- CASino integration with mobile apps HOT 1
- always getting Incorrect username or password. HOT 1
- CASino integration to several folder in AD using LDAP
- how to create a new user where is sign up ?
- How can we make salted md5, sha 256 or sha 512, compatible with CASino's ActiveRecord? HOT 1
- Rails 4.2 Asset Pipeline issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from casino.