Currently, ship containers only run in the foreground, It would be nice to have them run in a daemon mode. When moving the container to the background its logs also needs to be persisted in designated path.

Current Scenario:

If you look at the script where container is run, it doesn't use anything like & or nohup to move process to the background. Due to the limited time, it is left as it is. And log streaming was also commented out because it was conflicting with the container prompt

cgexec -g 'cpu,memory,pids:ship-'${CONTAINER_ID} \
    unshare --pid --mount --net --ipc --time --cgroup --uts --fork \
    chroot ${CONTAINER_ROOT}/ /bin/sh -c "mount -t proc proc /proc && $CMD" #2>&1 | tee ${SHIP_LOGS}/${CONTAINER_ID}/${CONTAINER_ID}.log || true

This issue can be used to suggest/improve/discuss the existing setup.

Acceptance Criteria

• Move container process in the background for non interactive mode.
• Possibly need to introduce some sort of flag to specify daemon mode.
• Moving container to background also need to pipe the container logs to /var/log/ship/${CONTAINER_ID}/${CONTAINER_ID}.log path.

Probelm

I got an error from grep command while removing the container with ship.

grep: warning: stray \ before white space

Also, for some of the command if root access is required then it didn't mention that.

Currently, there no automated testing so, every time there is any change. Reviewer or Tester must:

• clone the latest change
• test each subcommand
• publishes the results as screenshots for feedback or proof

This process is manual, error prone and time consuming so, it might lead to bad practices or laziness. So adding automated testing would help introduce efficiency.