Giter Club home page Giter Club logo

Comments (2)

Rayquaza01 avatar Rayquaza01 commented on July 21, 2024

Previously, an optional permission was used for notifications. When this permission was granted, the checkbox would be enabled.

In the new version, the notification permission is changed from being an optional permission to a required permission. Because of this, there is no longer a situation where the checkbox is disabled.

The reason I changed the notification permission to required is mainly because having an optional permission AND a toggle for notifications is redundant. Enabling notifications involved setting two options that both essentially mean the same thing. I think it should only be one or the other.

Notifications are still only sent when the checkbox is checked. If you do not enable notifications, History Cleaner will not send notifications.

from historycleaner.

Rayquaza01 avatar Rayquaza01 commented on July 21, 2024

I beleive this was fixed in 1.5.1. I had accidentally forgotten to check the notification setting when clearing ALL history. See 7cf43a5

from historycleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.