Giter Club home page Giter Club logo

Comments (3)

ejona86 avatar ejona86 commented on July 21, 2024 1

I'm a fan of the new timer trigger. I waited a bit after the update to comment to see how well it works. Every time it fires it does something, and it fires rarely. The idle timer was most frequently a noop. But I think that behavior is dependent on which delete behavior.

  • "Delete history older than a specified number of days." Simple timer makes sense here because running more than once a day is not beneficial. Idleness has nothing to do with it. Startup is weird, because then it keeps the history for potentially long periods; shutdown would make more sense, but that's not feasible I believe
  • "Delete all history." This setting only makes sense with a short (day or less) interval, as otherwine the history available will vary widely. I think idle timer makes the most sense here, although having startup in addition makes some sense (again, ideally shutdown, but I don't think that's feasible)

from historycleaner.

herrbrixter avatar herrbrixter commented on July 21, 2024 1

I'm fine to default to timer mode and depreciate idle mode. You could explain it better that timer 1440 means it deletes once every 24 hours. Just so it's easier to understand.

from historycleaner.

Rayquaza01 avatar Rayquaza01 commented on July 21, 2024

Just as an update to this:

The idle trigger was deprecated in Chrome in 1.6.0, and the Timer was made default. Idle trigger is still the default in Firefox, however I am planning to change that for 1.6.2

(For clarity, 1.6.1 is being skipped because I made a mistake while publishing the Firefox version of 1.6.0, so 1.6.1 and 1.6.0 are the same version)

Due to WebExtension Polyfill not currently supporting Manifest v3 (see mozilla/webextension-polyfill#329), I split the code base to remove the dependency on WebExtension Polyfill in Chrome. The Chrome source is under cr-src/ and the Firefox source is under src/. I'm planning to undo this split and remove the runtime dependency on WebExtension Polyfill entirely. (There will still need to be some duplicated files (such as the webpack config, manifest file, and background script), however much of the code works in both Manifest v2 and v3)

from historycleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.