The pictures used in the library are not ideal (especially the colors and contrast) and a version without a bank is missing. Postfinance has better ones available on their website in PDF format. If somebody is interested in implementing them or if you are searching for them (because it took me quite some time to find them), they can be found here:

https://www.postfinance.ch/de/cust/download/bizdoc.html

I have also created a drop-in replacement of the orange ESR gif specifically without bank:

If somebody wants to use it, this is how (with this class and the new gif in the same directory):

use SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip;

class ImprovedOrangePaymentSlip extends OrangePaymentSlip
{
  /**
   * Sets the default attributes of the elements for an orange slip
   *
   * @return $this The current instance for a fluent interface.
   */
  protected function setDefaults()
  {
    parent::setDefaults();

    $this->setSlipBackground(__DIR__.'/esr_ohne_bank.gif');

    $this->setRecipientLeftAttr(3, 15, 50, 4);
    $this->setRecipientRightAttr(66, 15, 50, 4);

    return $this;
  }
}

Currently the libary uses the now deprecated PSR-0 standard.
http://www.php-fig.org/psr/psr-0/

About PSR-4:
http://www.php-fig.org/psr/psr-4/

Consider implementing automatic word wrapping for text fields as explained in ravage84/SwissPaymentSlipFpdf/issues/9

In #8 I only used exceptions for invalid parameters.
The library should also throw exceptions when requesting disabled data.

Instead of using a monolithic design for all payment slips (currently orange and red), it would make the library more atomic if we would put the specific logic for red and orange slips (and any other) into sub classes, while preserving all common code in a generalized payment slip class.

That could look like this for the data classes:

• RedSlipData extends PaymentSlipData
• OrangeSlipData extends PaymentSlipData

And for the slip classes:

• RedSlip extends PaymentSlip
• OrangeSlip extends PaymentSlip

With #5 merged, we should not forget to assert the newly returned instances in both classes.

Under PHP 7.1 an error "A non-numeric value encountered" appears.

vendor\swiss-payment-slip\swiss-payment-slip\src\PaymentSlipData.php:897

Probably relevant:
dompdf/dompdf#1272
dompdf/dompdf#1331

Currently the libary returns true or false in most cases, in some always true, which does not make much sense.

A fluent interface would make the the API more comfortable.

Hi Marc Würth!
Just a clarification. The readme document says about using the library to produce Einzahlungsschein as PDFs.
Have you ever used the library to print on pre-printed Einzahlungsschein?

Using setSlipBackground(null); it is possible to print without a background. Just wondering how accurate it is in filling the fields on a pre-printed Einzahlungsschein.

Thanks in advance for any advice you can give!
Frederick

Dear Marc,

Is there any plan to adapt your library with new standard ISO 20022 which include QR Code?

Best regards and thanks for your very useful work 👍

An uncaught type error appears under PHP 7.0+:

PHP Fatal error: Uncaught TypeError: Argument 1 passed to SwissPaymentSlip\SwissPaymentSlip\PaymentSlip::__construct() must be an instance of SwissPaymentSlip\SwissPaymentSlip\PaymentSlipData, null given, called in /home/travis/build/ravage84/SwissPaymentSlip/tests/PaymentSlipTest.php on line 100 and defined in /home/travis/build/ravage84/SwissPaymentSlip/src/PaymentSlip.php:252

PHP 7.0 https://travis-ci.org/ravage84/SwissPaymentSlip/jobs/261917191
PHP 7.1 https://travis-ci.org/ravage84/SwissPaymentSlip/jobs/261917192
PHP 7.2 https://travis-ci.org/ravage84/SwissPaymentSlip/jobs/261917193

I have set 2714.05 with setAmount().
In the return value from function $paymentSlipData->getAmountCents() it is
2714.50.

The bug is in the code line 840 in PaymentSlipData.php

$ret = str_pad($cents, 2, '0', STR_PAD_RIGHT);

STR_PAD_RIGHT should be STR_PAD_LEFT then it works correctly.

In case of the amount is 114.9984, the result is 114 francs and 100 cents instead of 115 francs 0 cent.

1037ca0

It would make sense to have a reference number focused exception, e.g. ReferenceNumberException.

With so many changes done (mainly the sub classing), the tests probably do not reflect the actual code well enough anymore.

Also there is quite some duplicated/less optimal test code.

Currently an array of attribute settings describes where and how an element is places/displayed.

This leads to quite some amount of redundant code, such as the setAttributes() method.
This could be improved by using an object which encapsulates the attribute settings and the logic to set and retrieve these settings.

Each set of attribute settings contains the following attributes:

• posX
• posY
• width
• height
• background
• fontFamily
• fontSize
• fontColor
• lineHeight
• textAlign

Each element has it's own default attribute settings (depending on the type of payment slip).

Hi there. I wanted to install your library, however the installation instructions (https://github.com/ravage84/SwissPaymentSlip#installation) are unclear. Why am I required to create a composer.json (there already is one) and why am I supposed to run php composer.phar install, when there is no composer.phar file?

Currently we use PHPUnit 3.7.38 which is EOL.
We should update to PHPUnit 4.x, possibly to the latest version.

Currently the code requires PHP 5.3 as a minimum.
Since PHP 5.3 is EOL we should update the code to PHP 5.4 which would enable us to use the array short syntax.

It would make sense to have a banking customer ID focused exception, e.g. BankingCustomerIdException.

Currently the libary does not throw exceptions, e.g. in case of invalid inputs or if a disabled element is requested.

I'm not sure if throwing an exception in case someone requests a disabled element actually makes sense but in case of an invalid input it certainly is the better way than to either just don't set it it and not give any feedback or to not set it and return a simple false.

Currently the library only supports orange slips.

More information about the red (in)payment slips
https://www.postfinance.ch/en/biz/prod/pay/debsolution/inpay/detail.html?WT.mc_id=_shortcut_saisie-bv

https://www.postfinance.ch/en/cust/download/bizdoc.html
https://www.postfinance.ch/binp/postfinance/public/dam.qFz3PyxjANh-6a0WnQ7W3-1DP4pOpsqhHPT554zbfUQ.spool/content/dam/pf/de/doc/consult/templ/example/441031_templ_de_fr_it.pdf
https://www.postfinance.ch/binp/postfinance/public/dam.Qltruza-CeGOpP7C18BEwvTz0I4p1mykJoeaDhIfYl8.spool/content/dam/pf/de/doc/consult/templ/example/441032_templ_de_fr_it.pdf

Hi!
First of Marc Würth thanks for your hard work on this and the other Swiss Payment Slip PHP classes.
I am guessing from the todo on line 57 of PaymentSlipData.php:

• @todo Create a getRecipientData with formatting parameter, e.g. stripping blank lines

that there is currently no way to format individual lines of the RecipientData.

I found the public functions:
setRecipientLeftAttr()
getRecipientLeftAttr()
setRecipientRightAttr()
getRecipientRightAttr()

However it appears they set the same attributes for the Left or Right printings of the Recipient Data. I am guessing that new functions that allow setting the attributes on a per line bases would need to be added to do this.

My use case is the company name on line one of the recipient data lines is in a different font from the default and the company slogan on line two is in another different font from the default.

In any case just wanted to confirm that I was understanding this correctly.
God Bless!
Frederick

Currently the setNotForPayment() method does not respect if a certain field is disabled.
Thus if a field is disabled and someone calls setNotForPayment()it will result in a DisabledDataException.

All data classes are affected:
https://github.com/ravage84/SwissPaymentSlip/blob/0.11.1/src/OrangePaymentSlipData.php#L195-L196
https://github.com/ravage84/SwissPaymentSlip/blob/0.11.1/src/PaymentSlipData.php#L856-L860
https://github.com/ravage84/SwissPaymentSlip/blob/0.11.1/src/RedPaymentSlipData.php#L342-L343

Add a contribution guide like the following ones:
https://github.com/thephpleague/skeleton/blob/master/CONTRIBUTING.md
https://github.com/cakephp/cakephp/blob/master/CONTRIBUTING.md
https://github.com/ravage84/cakephp-multi-column-uniqueness/blob/master/CONTRIBUTING.md