Comments (7)
Using description='#{replace_entities(description)}'
did resolve the issue in my tests.
from nexpose-client.
Why is #to_xml building XML with Strings anyway?! Use Builder
or Nokogiri::XML::Builder
more robust that will handle the escaping for you.
from nexpose-client.
Looks like this can also happen with Credentials and Alerts.
from nexpose-client.
Yeah, looks like this code will benefit from being switched over to the XML objects instead of creating xml with strings.
from nexpose-client.
I'm pushing a quick fix for now. The string building is all over the place, so it will take some effort to clean up. As for Nokogiri, we don't want to introduce that dependency. But there is only one reason that I can think of for not switching to using the REXML libraries to do the same thing: If any code was depending upon the #to_xml calls to return a String, it will break if we switch over. That would require some more extensive testing internally just to make sure we don't break ourselves, let alone clients. A happy medium here might be to use the XML class, then to_s ourselves at the end?
from nexpose-client.
If you want to support calling the XML objects in a nested manner you could use #as_xml
to return REXML objects and #to_xml
to return String
. That would be similar to how #as_json
being a Hash/Array and to_json
being a String in Rails.
from nexpose-client.
Nice, I like that. That's something easy enough to add in over time.
from nexpose-client.
Related Issues (20)
- XML::VulnerabilityDetail/Complete API missing an instances value for vulnerabilities HOT 2
- Credentials failure after using Site.copy HOT 3
- Unknown SSH Handshake error HOT 5
- Api call to Generate Scan Engine Shared Secret HOT 1
- Is there any 2.1 API(i.e json support one) to get device vulnerability details ? HOT 3
- list_vuln_exceptions returns API error HOT 9
- APIError HTTP 500 when updating one tag with existing search_criteria HOT 3
- No data returned for vulnerability id and asset id in list_vuln_exceptions
- user.save(connection) causes a Null Pointer Exception HOT 1
- No method to save search criteria for a dynamic site? HOT 4
- Connection object `scan_devices` method failure on Global assets HOT 4
- api/3/assets/{id}/software returns HTTP.500 error HOT 2
- OpenSSL certificate verify failed HOT 7
- [QUESTION] How to generate Shared Secret via RESTful API? HOT 2
- job failure in servicenow HOT 1
- Login Failed when update nexpose-client 2.0.2 to 7.2.1 HOT 2
- Hostname not recognized by util.rb/convert with Ruby 2.6.3 HOT 2
- Stuck on maintenance mode page HOT 1
- Scan engine Issue HOT 1
- FQDN not recognized by util.rb/convert with Ruby 2.7.2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nexpose-client.