ralsina / devicenzo Goto Github PK

as

What steps will reproduce the problem?
1. Open DeVicenzo and open a URL
2. Open a new tab (in my case, ctrl+t)
3. Attempt to open a URL in the new tab (this didn't work)
4. Close the second tab
5. Attempt to open a new tab (failed)
6. Attempt to open a link from the only tab I had opened (segfault).

What is the expected output? What do you see instead?
Something somewhere went terribly wrong (ref. 
http://www.byrdbaggett.com/free/wallpapers/devolution350x262.jpg)

What version of the product are you using? On what operating system?
Ubuntu 10.10

Please provide any additional information below.
Here's the output. After closing the second tab I started getting the error 
about the underlying C/C++ object being deleted. When I tried to open a link 
from the first tab, I got the segfault.

$ python devicenzo.py 
** (<unknown>:9528): DEBUG: NP_Initialize
** (<unknown>:9528): DEBUG: NP_Initialize succeeded
** (<unknown>:9528): DEBUG: NP_Initialize
** (<unknown>:9528): DEBUG: NP_Initialize succeeded
** (<unknown>:9528): DEBUG: NP_Initialize
** (<unknown>:9528): DEBUG: NP_Initialize succeeded
** (<unknown>:9528): DEBUG: NP_Initialize
** (<unknown>:9528): DEBUG: NP_Initialize succeeded
java version "1.6.0_20"
OpenJDK Runtime Environment (IcedTea6 1.9.7) (6b20-1.9.7-0ubuntu1)
OpenJDK Server VM (build 19.0-b09, mixed mode)

(<unknown>:9528): Gdk-CRITICAL **: IA__gdk_window_get_origin: assertion 
`GDK_IS_WINDOW (window)' failed
Traceback (most recent call last):
  File "devicenzo.py", line 18, in <lambda>
    self.newtab = QtGui.QAction(QtGui.QIcon.fromTheme("document-new"), "New Tab", self, triggered=lambda: self.addTab(), shortcut="Ctrl+t")
  File "devicenzo.py", line 44, in addTab
    self.tabs.setCurrentIndex(self.tabs.addTab(Tab(url, self), ""))
  File "devicenzo.py", line 78, in __init__
    self.page().networkAccessManager().setCookieJar(container.cookies)
RuntimeError: underlying C/C++ object has been deleted
Traceback (most recent call last):
  File "devicenzo.py", line 18, in <lambda>
    self.newtab = QtGui.QAction(QtGui.QIcon.fromTheme("document-new"), "New Tab", self, triggered=lambda: self.addTab(), shortcut="Ctrl+t")
  File "devicenzo.py", line 44, in addTab
    self.tabs.setCurrentIndex(self.tabs.addTab(Tab(url, self), ""))
  File "devicenzo.py", line 78, in __init__
    self.page().networkAccessManager().setCookieJar(container.cookies)
RuntimeError: underlying C/C++ object has been deleted
Traceback (most recent call last):
  File "devicenzo.py", line 18, in <lambda>
    self.newtab = QtGui.QAction(QtGui.QIcon.fromTheme("document-new"), "New Tab", self, triggered=lambda: self.addTab(), shortcut="Ctrl+t")
  File "devicenzo.py", line 44, in addTab
    self.tabs.setCurrentIndex(self.tabs.addTab(Tab(url, self), ""))
  File "devicenzo.py", line 78, in __init__
    self.page().networkAccessManager().setCookieJar(container.cookies)
RuntimeError: underlying C/C++ object has been deleted
Traceback (most recent call last):
  File "devicenzo.py", line 18, in <lambda>
    self.newtab = QtGui.QAction(QtGui.QIcon.fromTheme("document-new"), "New Tab", self, triggered=lambda: self.addTab(), shortcut="Ctrl+t")
  File "devicenzo.py", line 44, in addTab
    self.tabs.setCurrentIndex(self.tabs.addTab(Tab(url, self), ""))
  File "devicenzo.py", line 78, in __init__
    self.page().networkAccessManager().setCookieJar(container.cookies)
RuntimeError: underlying C/C++ object has been deleted
Segmentation fault

i downloaded 
http://code.google.com/p/devicenzo/source/browse/trunk/devicenzo.py and when i 
run it i get a seg fault... might wanna look into to it.

patx@patx-desktop:~/Desktop$ python devicenzo.py.py
Traceback (most recent call last):
  File "devicenzo.py.py", line 168, in <module>
    wb.addTab(QtCore.QUrl('http://devicenzo.googlecode.com'))
  File "devicenzo.py.py", line 79, in addTab
    self.tabs.setCurrentIndex(self.tabs.addTab(Tab(url, self), ""))
  File "devicenzo.py.py", line 151, in __init__
    self.previewer = QtGui.QPrintPreviewDialog(paintRequested=self.wb.print_)
TypeError: 'print_()' has no overload that is compatible with 
'paintRequested(QPrinter*)'
Segmentation fault

What the summary says.

What steps will reproduce the problem?
1. Take the pretty version of browser script and launch it.
2. Try to add a bookmark

You'll get:

line 120, in bookmarkPage
    self.bookmarks[unicode(self.tabs.currentWidget().url.text())] = unicode(self.tabs.currentWidget().title())
AttributeError: 'QLineEdit' object has no attribute 'title'

I think you missed a "wb" member of a Tab here, so the correct version would be:

self.bookmarks[unicode(self.tabs.currentWidget().url.text())] = 
unicode(self.tabs.currentWidget().wb.title())

--
Still, you'll get another error. The problematic piece is (123-124):

self.star.setMenu(QtGui.QMenu())
[self.star.menu().addAction...

Notice you make an inline QMenu that'd probably be GC'ed really soon.
So then, when you access star's menu it's not there and you get:

AttributeError: 'NoneType' object has no attribute 'addAction'

At least it happens to me. A simple solution (not sure if right) is to anchor 
the QMenu with parent, so:

self.star.setMenu(QtGui.QMenu(self))