rakyll / autopprof Goto Github PK

A reference workflow as a screencast is required to demonstrate how the library works end to end.

Hi,
I try to contribute by adding more supported profiles (we need that as it was written in the comment) such as goroutine, block, allocs, mutex.
Essentially, I just call Lookup("profilename").WriteTo(w, debug) for each of them.
I'm not ready to submit the PR, as I'm not quite sure if the additional example that I put together for goroutine is sufficient.
Here is what I put together https://github.com/elumbantoruan/autopprof/tree/features/moresupportedprofiles
Appreciate for any feedback and suggestion

Hi,
Thanks for really helpful project.
I tested autopprof on Ubuntu 18.04.1 LTS with go 1.10.4, but got the error Cannot start pprof UI: exit status 1.
I changed your code a little bit to use exec.CombinedOutput() and got this message from stderr: invalid port number: strconv.Atoi: parsing "": invalid syntax.
I also tried to run this pprof command go tool pprof -http=: /tmp/profile-673928358 and got the same error so it seems we have to use a specific port for go tool pprof -http rather than just :.

My suggestion is we can just use a fixed port, it should be simple enough.
Thanks

Any plans to add Windows support as SIGQUIT is not supported on Windows?

Hey, nice project!

I am new to the Golang profiling world.
I was unsure what was the difference between standard pprof and autopprof.
After trying your example I think I understand the advantages of your project:

autopprof allows you to manually start the profiling at any arbitrary moment and for any specified duration.
As opposed to pprof which starts at the beginning of the program and can only be stopped manually (i.e. SIGINT) or when the program ends.

Did I get that right?
Your tool is very useful for newcomers, I think adding an explanation of the advantages of autopprof in the README would be helpful.

After running go mod tidy Docker dependency was removed from go.sum:

github.com/docker/docker v1.13.1 h1:5VBhsO6ckUxB0A8CE5LlUJdXzik9cbEbBTQ/ggeml7M=