raistlic / raistlic-lib-commons-core Goto Github PK

• clean up java docs
• mark deprecated code
• clean up param validations to use Param

• build status
• license
• test coverage
• current version

BigInteger pAll = Factorial.of(numberOfElements); BigInteger pPick = Factorial.of(numberToPick); BigInteger pRest = Factorial.of(numberOfElements - numberToPick); return pAll.divide(pPick.multiply(pRest));
when I use a amount of Elements ,Factorial's cache will cause a block or suspend ,I try to get a thread dump like below
` java.lang.Thread.State: RUNNABLE
at java.math.MutableBigInteger.divideMagnitude(MutableBigInteger.java:1494)
at java.math.MutableBigInteger.divideKnuth(MutableBigInteger.java:1227)
at java.math.MutableBigInteger.divideKnuth(MutableBigInteger.java:1163)
at java.math.MutableBigInteger.divideKnuth(MutableBigInteger.java:1221)
at java.math.BigInteger.divideKnuth(BigInteger.java:2065)
at java.math.BigInteger.divide(BigInteger.java:2046)
at com.mobi.utils.maths.Combination$DefaultAlgorithm.getCombinationCount(Combination.java:275)
at com.mobi.utils.maths.Combination$DefaultAlgorithm.fetchCombination(Combination.java:295)
Thanks you !

just use GCP cloudbuild, easier, more powerful & mostly free.

• refactor existing spock tests
• rewrite all other unit tests in spock
• package by package
• fix coverage
• fail build on coverage check failure

Combination.of(Arrays.asList(0,1,2,3,4,5,6,7,8,9),5)

Exception in thread "main" java.lang.NullPointerException
at org.raistlic.common.permutation.Factorial.of(Factorial.java:60)
at org.raistlic.common.permutation.Combination$DefaultAlgorithm.getCombinationCount(Combination.java:207)
at org.raistlic.common.permutation.Combination.(Combination.java:116)
at org.raistlic.common.permutation.Combination.of(Combination.java:85)
at org.raistlic.common.permutation.Combination.of(Combination.java:59)
at NumMax.main(NumMax.java:25)

The current maven central publish job does not generate/upload gpg signature files, so when promoting staging release in sonatype nexus, it fails with error message complaining signagure files missing.

It seems that maven plugin is pretty old and recent search suggests using maven-publish instead. This issue is to give it a try, also fix the gpg signing configuration.

the method 'of' in class org.raistlic.common.permutation.Factorial has a big bug in release 1.3, I see this bug was fixed in master brach, why not release a new version?

• add basic cloudbuild for gcp cloud build
• protect master branch