rafaelbroseghini / communipy Goto Github PK
View Code? Open in Web Editor NEW:books: :pencil2: Python, Learning, Sharing, Contributing :computer: :snake:
License: MIT License
:books: :pencil2: Python, Learning, Sharing, Contributing :computer: :snake:
License: MIT License
I have two suggestions regarding the Formatting of the practice files.
__ author __ is assigned the author name mostly.
and the date and filename can be generated if needed by __ file __ and os.path.getmtime(__ file __).
If needed then other meta information can be given as __ excercise __.
__author__="John Doe"
__excercise__="Strings" # optional
__date__ ="12/12/1234" # optional
"""some question"""
def taskx():
pass
"""some other question"""
def tasky():
pass
def taskx():
"""some question"""
pass
def tasky():
"""some other question"""
pass
The latter looks more neat to me.
math problems file is named math.py, if someone tries to import math in it, it will import itself.
CommuniPy/Practice Problems/05-Math/01-Beginner/math.py
Lines 3 to 4 in e805766
Instead of resolving the name problem comment is given that assume values instead of importing?
it should be renamed to maths.py
CommuniPy/Practice Problems/05-Math/01-Beginner/math.py
Lines 12 to 17 in e805766
Problem doesn't state what to do when number is negative, neither it says that number will only be positive.
Give proper conditions for input.
CommuniPy/Practice Problems/05-Math/01-Beginner/math.py
Lines 6 to 10 in e805766
Tell explicitly what to return eg.
"""
Given a number, return string 'even' if it is even or 'odd' if it is odd.
"""
Write tests.
Follow the guidelines from the Folder 'Strings'
Add project ideas following guideline on TEMPLATE.md within Project Ideas folder.
*.pyc should also be added else it will ignore the directory __ pycache __ but not the *.pyc files under it which is making it add __ pycache __ again and again.
Follow the template in test_strings.py for test cases.
Add dicts.py and test_dicts.py with exercises and test cases respectively.
Follow the guidelines in Folder 'Strings'
I will take care of this and submit a PR.
Follow guidelines in reverse_string.py
Instead of naming them Testers these should be named as
eg. StringsBeginnerTestCase.
Change the print statements to
print("\n.Passed 1. reverse_string with no errors!")
Extra space causing test case to fail.
CommuniPy/Practice Problems/05-Math/01-Beginner/math.py
Lines 7 to 9 in e805766
Improper indents make files look inconsistent.
Many pushes have these naive mistakes which make practice files look weird. Please add guidelines to CONTRIBUTING.md about submitting PEP8 compliant code or better, define standards by giving a template for additions.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.