radumas / crowdmap-basic Goto Github PK

View Code? Open in Web Editor NEW

17.0 5.0 111.0 364 KB

Basic example of using Leaflet.draw to crowdsource geographies to a CartoDB database

Home Page: https://radumas.info/crowdmap-basic

License: MIT License

PLpgSQL 10.59% CSS 7.63% HTML 81.78%

cartodb leaflet crowdmap leaflet-draw workshop

crowdmap-basic's People

Contributors

Stargazers

Watchers

Forkers

mjfoster83 btkempf lbrennee brianvan raphaeldumas neatengine kasolheim orst-iqbald outsidecreativ holly-transport jimmyrocks tomhillman pleasuredomeindustries laurenrenaud andrewthetm hanowsky antrim eunjunamkung rdelach hestermb rachriendeau rtclarkson carabalb johnpearson271 derekedwards krishnan-viswanathan adimac andyrutkowskiucla ayub567 plocl mappingmckenna lpuhl jonathan-marable slarrick sarstar gregjd hardikap369 bhavikpb wylieg123 sas1336 joshdelarosa1 todogeorge fener06 bradenanders saddamqaiser njander shane72 terratenney sumobility glunn asterix135 nazimabadi q-schen manamivi jdunca affah victorcleung mg231 jrootham choi3hr hanneglas codyevers danylaksono alleyhector aimarinello mentalhealthawhereness shopwhizzy felipemartenexen pio8909 akutokonou ajieaboganda mnccc civicdata pks48 crudder-renplan mndavey juliafruit kostassan geotgr3 ricky1221

crowdmap-basic's Issues

Harmonize use of hyphen versus underscore

crowdmap-basic vs crowdmap_basic

Borked in Firefox

I think this an HTTPS issue with the non-https URL of radumas.info

Add brief explanation of github, gh-pages, and cartodb

As I found out from the workshop given at Transportation Camp, people might come to the repository without really knowing what github & cartodb are...

After Forking this Repository, explain committing

Modify README so it doesn't jump around.

Add "Now What" Section

Should be a section explaining how to further customize the map, e.g.:

Change Basemap
Disable draw features
Change location

Toggle hiding data layer

Users should be able to hide already submitted shapes when drawing their own.

Cancel button should delete all drawn but not saved drawings

Explain how to see if the Carto SQL function created successfully

Upgrade to Leaflet 1.0?

Users experiencing issues loading mixed content

Document code

Data isn't saved if user input contains quotes

Discovered this with some feedback from a fork of this. From mentalhealthawhereness/map#1

I tried inserting a note that read I'm here... and the console revealed an error message
POST https://anditabinas.carto.com/api/v2/sql 400 (Bad Request)
(index):206 Problem saving the data
The sql that is being generated here is something like `SELECT insert_data('I'm here');' The issue is in where the sql string to get passed to the Carto sql API is being generated by simple string manipulation https://github.com/mentalhealthawhereness/map/blob/master/index.html#L199-210

A simple fix would be to replace any single-quote with the Postgresql-friendly doubled single quote SELECT insert_data('I''m here'); (see ex below) but I wonder if there's a.... better way of solving more cases of user-input that could break this. So I asked on StackOverflow
sanitized_input = user_input.replace("'", "''")