Giter Club home page Giter Club logo

Comments (5)

zernonia avatar zernonia commented on September 23, 2024 1

@epr3 I think we can do that. Since many component are doing the same, where visually hidden input were placed inside Primitive. However I would like this to be done in v2 instead of minor release. (I had a hunch it might cause some UI styling issue)

from radix-vue.

TheKvikk avatar TheKvikk commented on September 23, 2024 1

This is also happening with Switch component. If example code is used SwitchRoot is rendered as button without data-v-[id].

from radix-vue.

zernonia avatar zernonia commented on September 23, 2024

Thanks for the issue @dfagan2 ! I believe this is happening because in CheckboxRoot, we have multiple root node (additional input to cater for native form submission), thus the scoped data-attribute doesn't attached correctly to it.

Will look into this ASAP! 😁

from radix-vue.

epr3 avatar epr3 commented on September 23, 2024

@zernonia It looks like Vue 3 skips adding scoped styles on multi-root components, according to this issue here: vuejs/core#5446

Would it be beneficial to have the hidden input as a child of the root Primitive component (just below the <slot>)?

from radix-vue.

zernonia avatar zernonia commented on September 23, 2024

Yup. Some form components were having multiple root nodes thus causing scoped styles to not be applied correctly. It will be fixed in v2 😁

from radix-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.