Giter Club home page Giter Club logo

Comments (6)

zernonia avatar zernonia commented on May 23, 2024

Had a quick test with the reproduction link, seems like happy-dom doesn't behave as expected.

I've added a console.log of the state of html after clicking Toggle, and realized that something was off. The data-state somehow was closed.
https://stackblitz.com/edit/github-zsxecm-dphr8r?file=src%2Fcomponents%2F__tests__%2FRadixPopover.spec.ts

I tested the same on the current repo (using jsdom), seems to be working fine.

from radix-vue.

gu-stav avatar gu-stav commented on May 23, 2024

Oh you are right 🤦🏼 Apologies I must have overlooked that jsdom works without the Teleport stub.

Do you have any idea what kind of APIs might not be implemented in happy-dom? I've had a look, but my feeling is that it must come from floating-ui already, because neither Popover, Popper or Teleport contain any DOM related APIs that might be missing.

from radix-vue.

zernonia avatar zernonia commented on May 23, 2024

No sure tho, not quite familiar with happy-dom. In jsdom there's error being logged when DOM API were missing.
Perhaps there's a way to log that in happy-dom too?

from radix-vue.

gu-stav avatar gu-stav commented on May 23, 2024

I'll have a look 👍🏼 So far I couldn't make it log any error which makes me thing floating-ui swallows it somewhow.

What's your position on the Teleport stub? If you don't consider that a bug I'd go ahead and close this one and make sure to create a follow-up either for happy-dom or floating ui.

from radix-vue.

zernonia avatar zernonia commented on May 23, 2024

I'll take a look too. Let's keep this open for now so anyone using happy-dom for testing can comment if they have any resolution for this 😁

from radix-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.