rabobank-nederland / omnikassa-dotnet-sdk Goto Github PK

The approach used in the .NET sdk requires usage of a static Endpoint instance.

private static Endpoint omniKassa;
private static ApiNotification notification;

...which can lead to various issues. Especially this

public static Endpoint Create(String baseURL, byte[] signingKey, TokenProvider tokenProvider)
{
    OmniKassaHttpClient httpClient = new OmniKassaHttpClient(baseURL, signingKey);
    return new Endpoint(httpClient, tokenProvider);
}

...which news up a HttpClient internally.

This is not the recommended way to use HttpClient. It can lead to various issues; f.i. it requires a process to restart if you have to maintain static instances. It also prohibits proper dependency injection.

https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines